Skip to content

Disable group offset for tokamax gmm#4143

Open
NuojCheng wants to merge 1 commit into
mainfrom
fix-tokamax-gmm
Open

Disable group offset for tokamax gmm#4143
NuojCheng wants to merge 1 commit into
mainfrom
fix-tokamax-gmm

Conversation

@NuojCheng

@NuojCheng NuojCheng commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR fixes use_tokamax_gmm=true code path when use_ring_of_expert=false. It also adds an tokamax gmm AOT test.

Tests

CI tests and tokamax gmm AOT test (but skipped due to b/489205940)

Local test: https://paste.googleplex.com/6403591735738368. The compilation was successful.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@NuojCheng NuojCheng force-pushed the fix-tokamax-gmm branch 3 times, most recently from d722d04 to d1f4d33 Compare June 11, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant