Make GCP region configurable for managed ML diagnostics runs in MaxText#4130
Open
copybara-service[bot] wants to merge 1 commit into
Open
Make GCP region configurable for managed ML diagnostics runs in MaxText#4130copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
copybara-service
Bot
force-pushed
the
test_929618285
branch
4 times, most recently
from
7ed9174 to
d2ca044
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_929618285
branch
3 times, most recently
from
89cd5a2 to
c5daaf8
Compare
copybara-service
Bot
force-pushed
the
test_929618285
branch
from
c5daaf8 to
94874ee
Compare
to support multi-region deployments. `managed_mldiagnostics_region` defaults to empty string. When empty, the SDK will auto-detect the region from GCP metadata server. - Add strictly typed `managed_mldiagnostics_region`: str = "" to `ManagedMLDiagnostics` Pydantic class in `types.py`. - Add `managed_mldiagnostics_region`: "" to `base.yml`. - Pass configured region directly to `machinelearning_run` in `managed_mldiagnostics.py`, falling back to `None` if empty to trigger SDK auto-detection. PiperOrigin-RevId: 929618285
copybara-service
Bot
force-pushed
the
test_929618285
branch
from
94874ee to
459aea3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make GCP region configurable for managed ML diagnostics runs in MaxText
to support multi-region deployments.
managed_mldiagnostics_regiondefaults to empty string. When empty,the SDK will auto-detect the region from GCP metadata server.
managed_mldiagnostics_region: str = "" toManagedMLDiagnosticsPydantic class intypes.py.managed_mldiagnostics_region: "" tobase.yml.machinelearning_runinmanaged_mldiagnostics.py, falling back toNoneif empty to trigger SDK auto-detection.