fix: support CJK title and author identity matching - #16
Closed
xzjncu wants to merge 1 commit into
Closed
Conversation
…fold; add full CJK name equality check for leading author matching
- normalize_title(): replace ASCII-only a-z0-9 filter with unicodedata.normalize("NFKC") + character.isalnum() to retain CJK/Unicode characters
- _full_leading_author_matches(): add NFKC+casefold full-name equality check before falling back to per-part comparison
- _leading_author_status(): add normalized full-name equality as a match condition alongside family-name key comparison
Fixes source_pdf_mismatch false negatives for Chinese-titled papers (e.g. same title/author previously scored title_similarity=0.0, leading_author=conflict).
Owner
|
Thank you, @xzjncu, for identifying and fixing the CJK title/author false-negative path. We have incorporated your original authored commit ( The integration is now continued in #20. Your commit and authorship remain part of that PR's history. We are closing this PR to avoid duplicate integration; #20 has not been merged into Thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_title()retains alphanumeric characters from all scripts (not just ASCII a-z0-9) viaunicodedata.normalize("NFKC")+character.isalnum(), so Chinese/Japanese/Korean titles no longer collapse to empty strings_full_leading_author_matches()before the per-part fallback, and a normalized full-name equality condition in_leading_author_status()— so identical CJK names like "朱云鹃" match correctly instead of degrading toconflictTest plan
python3 -m py_compile scripts/common.py