fix: preserve blank pagination parameters#195
Conversation
|
@kriptoburak is attempting to deploy a commit to the Daiki Urata's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Addressed the requested scope change in 198d0bd: removed the redundant service-specific test and kept only the #177 pagination fix with focused regression coverage. The review thread is resolved. Build, Biome, and all 71 tests pass. The only non-code status is the maintainer-controlled Vercel authorization check. Ready for re-review, @7nohe. |
|
Closing this because the maintainer-requested scope now intentionally contains no Xquik placement. The accepted generic pagination fix should remain a separately scoped upstream contribution if the maintainer wants it, but this branch no longer serves the Xquik integration goal. Thanks for the detailed review. |
Summary
initialPageParaminstead of coercing it to0initialPageParamhere. My api expects no or an empty initial page parameter.initialPageParam=""generates code that sendspage=0. I believe the reason is thatformatOptions => safeParseNumberconverts the empty string to0. #177Validation
pnpm buildpnpm lintpnpm test -- --run(71 passed, 1 skipped)git diff --checkThe remaining Vercel authorization status requires maintainer approval.