Skip to content

Fix GBrain portability issues for cross-machine/user compatibility - #4

Merged
6900-sudo merged 1 commit into
mainfrom
claude/gbrain-repo-e9w7yo
Sep 23, 2026
Merged

6900-sudo merged 1 commit into
mainfrom
claude/gbrain-repo-e9w7yo

Conversation

@6900-sudo

Copy link
Copy Markdown
Owner

Summary

This PR addresses portability concerns identified in the GBrain integration code review. The changes ensure the integration works correctly for any user and machine, not just root.

Changes

MCP Configuration Fix

  • Removed: Hard-coded /root/.gbrain path in .claude/mcp/gbrain.json
  • Result: MCP config now uses default GBRAIN_HOME resolution, portable across all users and machines

Documentation Improvements

  • GBRAIN_QUICKSTART.md: Added explicit gbrain init step as the first step
  • GBRAIN_INTEGRATION.md: Updated setup status and instructions to clarify repo-level vs. local setup
  • .claude/gbrain-setup.md: Added clear section separating repository files from local user state (~/.gbrain)

Key Distinction

The documentation now clearly separates:

  • Repository-level: .claude/mcp/gbrain.json, docs/GBRAIN_*.md (committed to git)
  • Local user setup: ~/.gbrain/ directory (initialized on each user's machine)

Testing

These changes have been verified to:

  • Allow MCP to function for any user (not just root)
  • Provide clear setup instructions for new developers
  • Maintain backward compatibility with existing configurations

Related Issues

Addresses code review feedback from previous GBrain integration PR regarding hard-coded paths and documentation clarity.


🤖 Generated with Claude Code

https://claude.ai/code/session_01V7WwPomB1noJPWBgdQ1Vsg


Generated by Claude Code

- Remove hard-coded /root/.gbrain path from MCP configuration
- Use default GBRAIN_HOME resolution for portability across users/machines
- Clarify documentation: separate repo-level config from local setup
- Update GBRAIN_QUICKSTART.md to include initial gbrain init step
- Update GBRAIN_INTEGRATION.md setup status and instructions
- Add clear distinction between repository files and user's ~/.gbrain state
- Correct step numbering in quick start guide

These changes address the portability concerns identified in code review:
- MCP config now works for any user, not just root
- Documentation no longer conflates local state (~/.gbrain) with repo files
- New developers get clear instructions to initialize their own brain locally
@6900-sudo
6900-sudo marked this pull request as ready for review September 23, 2026 04:24
@6900-sudo
6900-sudo merged commit 167dcf3 into main Sep 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants