Skip to content

bug: fix tournament match substitute lineups #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukepolo merged 4 commits into from
Jun 2, 2026
Merged

bug: fix tournament match substitute lineups #275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a5a789
Fix tournament match substitute lineups
zeeshaun May 30, 2026
4c76be5
Keep tournament scheduler fix in Hasura functions
zeeshaun May 31, 2026
91dadfc
Use tournament max lineup size when scheduling
zeeshaun Jun 1, 2026
93394ac
fix: cap tournament lineup by match options; dedupe lineup loop
lukepolo Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 37 additions & 14 deletions hasura/functions/tournaments/schedule_tournament_match.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ CREATE OR REPLACE FUNCTION public.schedule_tournament_match(bracket public.tourn
tournament tournaments;
stage tournament_stages;
member RECORD;
_lineup RECORD;
_lineup_1_id UUID;
_lineup_2_id UUID;
_captain_steam_id_1 bigint;
Expand All @@ -17,6 +18,7 @@ CREATE OR REPLACE FUNCTION public.schedule_tournament_match(bracket public.tourn
_match_options_id UUID;
_round_best_of int;
_swiss_match_type text;
_max_players_per_lineup int;
BEGIN
IF bracket.match_id IS NOT NULL THEN
RETURN bracket.match_id;
Expand Down Expand Up @@ -138,6 +140,12 @@ CREATE OR REPLACE FUNCTION public.schedule_tournament_match(bracket public.tourn
RETURNING lineup_1_id, lineup_2_id
INTO _lineup_1_id, _lineup_2_id;

-- Cap by the match's own options (a clone), not the tournament default.
SELECT match_max_players_per_lineup(m)
INTO _max_players_per_lineup
FROM matches m
WHERE m.id = _match_id;

SELECT tt.captain_steam_id
INTO _captain_steam_id_1
FROM tournament_teams tt
Expand All @@ -148,20 +156,35 @@ CREATE OR REPLACE FUNCTION public.schedule_tournament_match(bracket public.tourn
FROM tournament_teams tt
WHERE tt.id = bracket.tournament_team_id_2;

FOR member IN
SELECT * FROM tournament_team_roster
WHERE tournament_team_id = bracket.tournament_team_id_1
LOOP
INSERT INTO match_lineup_players (match_lineup_id, steam_id)
VALUES (_lineup_1_id, member.player_steam_id);
END LOOP;

FOR member IN
SELECT * FROM tournament_team_roster
WHERE tournament_team_id = bracket.tournament_team_id_2
FOR _lineup IN
SELECT * FROM (VALUES
(_lineup_1_id, bracket.tournament_team_id_1, _captain_steam_id_1),
(_lineup_2_id, bracket.tournament_team_id_2, _captain_steam_id_2)
) AS l(match_lineup_id, tournament_team_id, captain_steam_id)
LOOP
INSERT INTO match_lineup_players (match_lineup_id, steam_id)
VALUES (_lineup_2_id, member.player_steam_id);
FOR member IN
SELECT ttr.*
FROM tournament_team_roster ttr
INNER JOIN tournament_teams tt
ON tt.id = ttr.tournament_team_id
LEFT JOIN team_roster tr
ON tr.team_id = tt.team_id
AND tr.player_steam_id = ttr.player_steam_id
WHERE ttr.tournament_team_id = _lineup.tournament_team_id
ORDER BY
CASE WHEN ttr.player_steam_id = _lineup.captain_steam_id THEN 0 ELSE 1 END,
CASE tr.status
WHEN 'Starter' THEN 1
WHEN 'Substitute' THEN 2
WHEN 'Benched' THEN 3
ELSE 4
END,
ttr.player_steam_id
LIMIT _max_players_per_lineup
LOOP
INSERT INTO match_lineup_players (match_lineup_id, steam_id)
VALUES (_lineup.match_lineup_id, member.player_steam_id);
END LOOP;
END LOOP;

IF _captain_steam_id_1 IS NOT NULL THEN
Expand Down Expand Up @@ -200,4 +223,4 @@ CREATE OR REPLACE FUNCTION public.schedule_tournament_match(bracket public.tourn

RETURN _match_id;
END;
$$;
$$;