Skip to content

ci: run DCAF regression tests automatically and fix test expectations - #32

Open
ErikGaida wants to merge 6 commits into
developmentfrom
feature/integration-test
Open

ci: run DCAF regression tests automatically and fix test expectations#32
ErikGaida wants to merge 6 commits into
developmentfrom
feature/integration-test

Conversation

@ErikGaida

@ErikGaida ErikGaida commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

This PR enables automatic execution of the existing DCAF regression suite through GitHub Actions.

  • Run the build and regression tests on every push.
  • Execute the existing tests using meson test -C build regression --print-errorlogs.
  • Install the required test dependencies: python3-h2 and util-linux-extra

@ErikGaida ErikGaida self-assigned this Aug 27, 2026
@jordijoangimenez

jordijoangimenez commented Aug 28, 2026

Copy link
Copy Markdown

Please move the tests out from the docker folder to the test folder.

@ErikGaida
ErikGaida force-pushed the feature/integration-test branch from 0543e5d to 8ece423 Compare August 28, 2026 12:05
@ErikGaida

ErikGaida commented Aug 28, 2026

Copy link
Copy Markdown
Author

@jordijoangimenez, I rebased the branch onto development and moved the files into a directory under tests.

@dsilhavy dsilhavy added this to the v1.2.0 milestone Sep 2, 2026
jordijoangimenez added a commit that referenced this pull request Sep 29, 2026
@jordijoangimenez
docs: describe the README as of #32 merged
f4b0bca 
Problem
  The open pull request #32
  (feature/integration-test -> development) adds pytest integration
  tests under tests/integration/, with their own README. It does not
  change the root README, so after it merges the root README would not
  mention them.  [code-derived]

Basis
  No clause governs this; code-derived. Merged state built by merging
  #32 (head b5cbcf7) into development (cef77bc), no conflicts. #32
  changes only tests/integration/ and adds .gitignore.

Raised by
  Review by the repository owner.

Change
  README.md, Development: a short "Integration tests (optional)"
  subsection pointing to tests/integration/README.md. What it says is
  taken from the merged tree: the tests run against a local DCAF from
  docker/local (tests/integration/README.md; docker/local/
  docker-compose.yml:21-23 maps ports 5000, 5100 and 5201, as
  tests/integration/config.toml expects); the clients create, get and
  delete R1 provisioning sessions and data reporting configurations, R2
  data reporting sessions (plus creating a report) and R6 event
  subscriptions (tests/integration/clients/*.py); there is no update
  call. No instruction is copied from the sub-folder README.
  The rest of the README was checked against the merged tree and is
  unchanged by #32.

Verification
  T0: code_check.py against the previous README on this branch: 8 of 8
  code blocks byte-identical, none added. The tests were not run.

Not in this change
  tests/integration/README.md itself; any code.
@jordijoangimenez jordijoangimenez mentioned this pull request Sep 29, 2026
Open
@dsilhavy

dsilhavy commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@ErikGaida :

  • Please compare this against the existing testsuite and remove duplicates
  • Add automatic test execution as a GitHub action

@ErikGaida ErikGaida closed this Oct 9, 2026
@ErikGaida
ErikGaida force-pushed the feature/integration-test branch from b5cbcf7 to cef77bc Compare October 9, 2026 09:03
@ErikGaida

ErikGaida commented Oct 9, 2026

Copy link
Copy Markdown
Author

I compared the Python integration test with the existing regression suite and removed it because it largely duplicated existing coverage. I reset the feature branch to the base branch, leaving no diff, so GitHub automatically closed the PR. I’ll reopen it shortly with the GitHub Actions update to run the existing regression tests automatically.

@ErikGaida ErikGaida reopened this Oct 9, 2026
@ErikGaida

ErikGaida commented Oct 9, 2026

Copy link
Copy Markdown
Author

The build workflow was disabled, so no CI runs were triggered by my pushes. I re-enabled it using gh workflow enable build.yml --repo 5G-MAG/rt-data-collection-application-function. Future pushes will now trigger the build and existing regression tests.

@ErikGaida

ErikGaida commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Hi @davidjwbbc , the regression tests fail because they expect 200 OK when creating a provisioning session, but DCAF returns 201 Created:

(E): 001_provisioning_session:create_ue_comm_provisioning_session: Unexpected response code 201

It looks like b807fab changed the response status to 201, but the corresponding test expectations were not updated.

@ErikGaida ErikGaida changed the title Add end-to-end CRUD integration coverage for DCAF R1, R2, and R6 APIs ci: run DCAF regression tests automatically and fix test expectations Oct 14, 2026
davidjwbbc
davidjwbbc requested changes Oct 16, 2026
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
@ErikGaida
ErikGaida requested a review from davidjwbbc October 16, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidjwbbc davidjwbbc davidjwbbc approved these changes
@dsilhavy dsilhavy Awaiting requested review from dsilhavy
@rjb1000 rjb1000 Awaiting requested review from rjb1000
@devbbc devbbc Awaiting requested review from devbbc
@jordijoangimenez jordijoangimenez Awaiting requested review from jordijoangimenez

Assignees

@ErikGaida ErikGaida

Labels

None yet

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ErikGaida @jordijoangimenez @dsilhavy @davidjwbbc