Repository navigation
Say which browsers the README's browser paragraph describes - #38
Merged
Merged
Conversation
The paragraph described BrowserDrivers as if it started every browser, but the 51Did harness starts its own Chrome and Firefox. It never looks for a driver the machine provides and never makes a first start. The paragraph now names BrowserDrivers, and one sentence says what the harness shares and what it does differently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The "Browser" paragraph of
README.md, under "How a run is wired", describesHelpers/BrowserDrivers.csas if it started every browser in the suite. It does not start the 51Did tests' browsers, becauseBrowser51Did/Harness.csstarts their Chrome and Firefox itself. Two sentences were therefore untrue of those tests.CHROMEWEBDRIVER,GECKOWEBDRIVERorEDGEWEBDRIVERor found on the path". The harness creates its driver services without a path, so Selenium Manager finds or fetches the driver.BrowserDrivers.StartOnce.Found in review of #37.
The change
The paragraph now opens by saying tests get their browsers from
BrowserDrivers, and says Chrome and Firefox are started once before the first test that asksBrowserDriversfor them. One sentence is added at the end. It says the harness starts the 51Did tests' browsers itself, with the same time limit, arguments and quiet drivers, which #37 gave it, but leaves Selenium Manager to find or fetch the driver and makes no first start. No code changes.How it was checked
Each statement was read against
rcat c33ac84.Harness.Startcreates local sessions withBrowserDrivers.ChromeService(null)andFirefoxService(null), so no driver path is given, withSessionTimeoutSeconds, and creates remote sessions throughBrowserDrivers.CreateRemote.Harness.NewChromecallsBrowserDrivers.AddChromeArguments.Browser51DidcallsStartOnceorFindDriver.