Repository navigation
Start the .NET demo with the _51DEGREES_ names as well as the older ones - #32
Merged
Merged
Conversation
… name The harness's comments, its not-configured message and both READMEs still said the demo is handed only the older names. They now say it is given the key and the endpoint under each name it reads, which for the dotnet demo is the _51DEGREES_ names and the older ones. The comment on the older names says older versions read only those, as the latest release reads the _51DEGREES_ names first. The test now asserts the older endpoint name as well, so it checks all four names it sets.
This was referenced Nov 16, 2026
jwrosewell
marked this pull request as ready for review
November 16, 2026 11:30
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
NoClientScriptTag_PmpAddsItAndTheAnswerStillCreatesinBrowser51Did/PmpAddsClientScriptTests.csfails when the suite runs in a CI job that also holds_51DEGREES_RESOURCE_KEY_51DID:The .NET demo the suite starts (
examples/device-detection/Cloud/pmp-webin 51degrees-dotnet) reads its key from_51DEGREES_RESOURCE_KEYfirst, then from the CI name_51DEGREES_RESOURCE_KEY_51DID, and only then from the older51DEGREES_RESOURCE_KEY(Settings.FromEnvironment, lines 130 to 160).ExampleApps.Demosstarted the demo with51DEGREES_RESOURCE_KEYalone, and the demo process inherits the job's environment. So where the job holds_51DEGREES_RESOURCE_KEY_51DID, the demo used that key instead of the one the harness handed it, and the test, which checks the script was asked for with the harness's key, failed.The change
ExampleApps.Demos["dotnet"]sets_51DEGREES_RESOURCE_KEYand_51DEGREES_CLOUD_ENDPOINTas well as the older names, as Give the .NET example the _51DEGREES_ variable names alongside the old ones #25 did for the .NET getting started example (commit 5c3f519). The key the suite hands over is then the first one the demo reads. Older versions of the demo read only the older names, so both are kept. The latest release, device-detection/4.5.181 at 8b3220b3a9, reads the_51DEGREES_names first.CloudUrlandResource, its not-configured message, the rootREADME.mdandBrowser51Did/README.mdsaid the demo is handed only the older names. They now say it is given the key and the endpoint under each name it reads.ExampleApps.csand the test's message say "older versions" where they said "released versions".Demos_Dotnet_SetsTheUnderscoreNamesasserts all four names it sets, the older51DEGREES_CLOUD_ENDPOINTincluded.How it was checked
Demos_Dotnet_SetsTheUnderscoreNames. Locally at 7337818 the build has no warnings, and the example and demo settings tests pass, 10 of 10.NoClientScriptTag_PmpAddsItAndTheAnswerStillCreatesran with51DEGREES_RESOURCE_KEYand_51DEGREES_RESOURCE_KEY_51DIDholding different keys, which is the case described above.What remains
_51DEGREES_RESOURCE_KEYor_51DEGREES_CLOUD_ENDPOINT, and read the older key name before the CI name, the other way round from the demo. A job that set only the_51DEGREES_names therefore had every browser test skip as not configured, and still passed. That is fixed separately in Read the _51DEGREES_ names for the demo's key and endpoint, before the older ones #35, a draft stacked on this branch, which is to be retargeted torcbefore this one merges.maintogether with the shared choice wait (Wait for the shared store read in the shared choice test #29) and the browser start-up fixes (Start Chrome and Firefox once before the first test that uses them #28 and Give every Chrome and Firefox session the first start's time limit #34) already inrc.