Repository navigation
Specification conformance, 51degrees-python, the REFRESH_TRIES public name - #236
Closed
jwrosewell wants to merge 2 commits into
Closed
jwrosewell wants to merge 2 commits into
jwrosewell wants to merge 2 commits into
Conversation
fiftyone_pipeline_engines 4.5.43 published REFRESH_TRIES = 1 in datafile_update_service, and #220 moved it into DataFileUpdateService. The test reads the name from the module and expects 4.5's value and a DeprecationWarning.
Pull request 220 moved REFRESH_TRIES into DataFileUpdateService as 10 and removed the module level name that fiftyone_pipeline_engines 4.5.43 published as 1, so code that imported it failed with an ImportError. The module's __getattr__ gives the name again with 4.5's value and a DeprecationWarning that names DataFileUpdateService.REFRESH_TRIES, because nothing in the package reads it now.
Contributor
Author
|
Closed as superseded. This restores the same public name as 51degrees-python#230, which was reviewed with no findings and merged into rc at 15:55 on 16 November as 3b07802. Both add a module getattr in datafile_update_service.py giving REFRESH_TRIES with the value 1 and a DeprecationWarning naming DataFileUpdateService.REFRESH_TRIES, so only one can merge and #230 got there with its red run and full build done. If the remote fleet had a reason for a second implementation that the diff does not show, say so and this can be reopened. Closed by the release coordinator under James's 13 November agreement that our own superseded pull requests are closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification this brings the code into conformance with
Commits (2, on rc)
What remains
This draft is not ready for review yet. Its description, with the runs that show each test failing and then passing, is written once its full build has finished.