Skip to content

Specification conformance, 51degrees-python, the REFRESH_TRIES public name - #236

Closed
jwrosewell wants to merge 2 commits into
rcfrom
remote/python-refresh-tries
Closed

jwrosewell wants to merge 2 commits into
rcfrom
remote/python-refresh-tries

Conversation

@jwrosewell

Copy link
Copy Markdown
Contributor

The specification this brings the code into conformance with

  • Each commit below names the specification item it answers.

Commits (2, on rc)

  • Test that the module level REFRESH_TRIES still imports, with 4.5's value
  • Keep the module level REFRESH_TRIES readable, deprecated

What remains

This draft is not ready for review yet. Its description, with the runs that show each test failing and then passing, is written once its full build has finished.

fiftyone_pipeline_engines 4.5.43 published REFRESH_TRIES = 1 in
datafile_update_service, and #220 moved it into DataFileUpdateService.
The test reads the name from the module and expects 4.5's value and a
DeprecationWarning.
Pull request 220 moved REFRESH_TRIES into DataFileUpdateService as 10 and
removed the module level name that fiftyone_pipeline_engines 4.5.43
published as 1, so code that imported it failed with an ImportError. The
module's __getattr__ gives the name again with 4.5's value and a
DeprecationWarning that names DataFileUpdateService.REFRESH_TRIES,
because nothing in the package reads it now.
@jwrosewell jwrosewell added the remote-conformance Brings the code into conformance with the specification label Nov 16, 2026
@jwrosewell

Copy link
Copy Markdown
Contributor Author

Closed as superseded. This restores the same public name as 51degrees-python#230, which was reviewed with no findings and merged into rc at 15:55 on 16 November as 3b07802. Both add a module getattr in datafile_update_service.py giving REFRESH_TRIES with the value 1 and a DeprecationWarning naming DataFileUpdateService.REFRESH_TRIES, so only one can merge and #230 got there with its red run and full build done. If the remote fleet had a reason for a second implementation that the diff does not show, say so and this can be reopened. Closed by the release coordinator under James's 13 November agreement that our own superseded pull requests are closed.

@jwrosewell jwrosewell closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remote-conformance Brings the code into conformance with the specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant