Skip to content

Report how the update on start-up ended, and schedule the next check - #233

Draft
jwrosewell wants to merge 3 commits into
rcfrom
fix/startup-check-reported
Draft

jwrosewell wants to merge 3 commits into
rcfrom
fix/startup-check-reported

Conversation

@jwrosewell

Copy link
Copy Markdown
Contributor

Draft opened with the tests alone, so the red run shows them failing on rc. The body follows when the fix and its full build are in.

An error the errors table does not name, raised in the update on start-up,
was neither reported to the update complete callbacks nor followed by the
next check, and it was raised into the code that registered the data file,
so building a Pipeline could fail on it. Update polling catches such an
error, reports it as AUTO_UPDATE_UNKNOWN_ERROR and schedules the next
check, and the specification asks for every check to be reported once it
ends, the update on start-up included.
The first version of these tests expected the update on start-up to log
its error and swallow it, as update polling does. The specification says
the opposite for the update on start-up, which passes the error to its
caller instead of logging it, while still reporting how the check ended
and still scheduling the next check.
An error the errors table does not name, raised in the update on start-up,
was neither reported to the update complete callbacks nor followed by the
next check. The specification asks for every check to be reported once it
ends, the update on start-up included, for the update on start-up to pass
its error to the caller rather than logging it, and for a failure never to
stop later checks. The error is now reported as AUTO_UPDATE_UNKNOWN_ERROR,
which schedules the next check, and is then raised on to the caller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant