Skip to content

Require the version of each package that holds the names imported - #231

Draft
jwrosewell wants to merge 3 commits into
rcfrom
fix/package-minimum-versions
Draft

jwrosewell wants to merge 3 commits into
rcfrom
fix/package-minimum-versions

Conversation

@jwrosewell

Copy link
Copy Markdown
Contributor

Draft opened with the test alone, so the red run shows it failing on rc. The body follows when the fix and its full build are in.

Four packages here import a name that came in with this release's version
of another package here, and none of the four requires that version, so
pip leaves an older copy of the dependency in place when the importing
package alone is upgraded and the import fails. The test reads the names,
the module that holds each one and each package's install_requires from
the checkout.
Four packages here import a name that is new in this release's version of
another package here. Each now requires that version, so that upgrading
one of the four on its own brings the dependency with it rather than
leaving an older copy in place and failing at import.
A pull request that changes no counted file of a dependency leaves that
dependency at its last release, so a requirement naming the version this
release gives it cannot be met from the checkout and pip looks for that
version on a package index, where it does not exist yet. The build of the
four new minimum versions failed in all ten Build and Test jobs for
exactly that reason, with "No matching distribution found for
fiftyone_pipeline_engines>=4.5.44".

Writing the version each package is required at, when that is higher than
the version this commit would release it at, keeps the checkout consistent
with itself. Nothing published changes, because the publish builds each
package at the version its release plan gives it and not from version.txt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant