Repository navigation
Test that an on-premise engine configured with no Property names is created with none - #210
Merged
Merged
Conversation
The comment said the engine still gives every property, where the test reads one property. It now says a property is still given when read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests only. An on-premise Device Detection or IP Intelligence engine configured with no Property names creates its native engine with none, rather than with the data set's names, and no test held that.
What the specification says
device-detection-on-premise.md lines 188 to 193 at 706de1f0, and the same sentence in ip-intelligence-on-premise.md lines 394 to 399:
What changed
cd935eb1, a test in eachtest_keys_and_property_list.py, and from the review4cbe6acd, which says in the Device Detection test's comment what the test reads. Each engine keeps the names it gives the native engine asbuild_property_names(devicedetection_onpremise.pyat ace2d677,ipintelligence_onpremise.py), being the list the native engine is built from.test_no_names_builds_the_engine_with_nonein Device Detection builds a Pipeline with norestricted_properties, findsbuild_property_namesempty, and still readsIsMobilefor a mobile User-Agent.build_property_namesempty.How it was verified
Both tests pass on
rc, as the engines already behave this way, so a guard run shows each can fail.546a33e5, being the earlier head cd935eb plus a throwaway workflow and a guard that gives each engine one name when none is configured. It failed as it should on Ubuntu and Windows. The Device Detection test fails on its own assertion,Lists differ: [] != ['IsMobile'], and all four tests of the IP Intelligence file'sPropertyListTestsfail in its setUp with2 != 1, because the engine built with no names then holds only the guard's one name.tmp/pr-matrix-210b, the head 4cbe6ac merged withrcf583e6b, green in all ten Build and Test jobs on the first attempt, with 11 of 11Setting 'PullRequestSha'lines on 4cbe6ac and Configure printing "Left out 5 macOS entries". macOS was left out of this draft's full build under the 9 November decision. The rc head is built with macOS before it merges into main.tmp/pr-matrix-210, the earlier head cd935eb merged withrcace2d67, green in all ten Build and Test jobs. Its attempt 1 failed only in Ubuntu_Python_3.13, in the shared Selenium contract tests, whereSessionStorageCache_FireFox (True)could not start a Firefox session within Selenium's 60 second limit, and that job passed when run again. The fix for that limit is drafted in the shared tests, selenium-api-tests#28 and #34.What it releases
Nothing. Only tests change.
What remains
Nothing for this change.