Repository navigation
Name the elements of each pipeline in its usage sharing records - #202
Merged
Merged
Conversation
jwrosewell
marked this pull request as ready for review
November 15, 2026 18:31
This was referenced Nov 15, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One usage sharing element in several pipelines writes, in each record, the flow elements of the pipeline the request came from. It replaces #199, which was stacked on #193, so that it does not wait for #193's Package element.
Problem
The record's constant part, which names the flow elements of the pipeline, was made from the element's one pipeline (
share_usage.pyat cdd53eef,get_constant_xmlandget_flow_elements). In more than one pipeline the element logged a warning that it was "registered to too many pipelines" and sent records naming no flow elements at all.What the specification says
multi-pipeline-elements.md lines 16 to 19 at 706de1f0:
What changed
847ed666, the test, a newtest_share_usage_pipelines.py. One usage sharing element in two pipelines, each with an element of its own, processes a request in each. The record of each request names the flow elements of its own pipeline.2a42c979, the change.get_data_from_evidencekeeps the request's pipeline on itsShareUsageData, andadd_to_share_usageasksget_constant_xmlfor that pipeline's constant part. It is made once for each pipeline, once the server address has been looked up, and kept.get_constant_xmlandget_flow_elementstake the pipeline as an argument that may be left out, and with none they do what they did before, soconstant_xmland the warning for more than one pipeline still work for a caller that gives none.How it was verified
rccdd53ee) plus a throwaway workflow. On Ubuntu and Windows the new test failed, as both records named no flow elements, and the package's tests gave "1 failed, 109 passed".tmp/pr-matrix-202, the head 2a42c97 merged withrccdd53ee, green in all ten Build and Test jobs, with 11 of 11Setting 'PullRequestSha'lines on 2a42c97 and Configure printing "Left out 5 macOS entries". macOS was left out of this draft's full build under the 9 November decision. The rc head is built with macOS before it merges into main.What it releases
fiftyone_pipeline_engines_fiftyoneand its dependants, which Monday's release plan releases already.What remains
#199 is for closing, as this replaces it.