Repository navigation
Specification conformance, 51degrees-java, examples that build from a fresh clone - #192
Draft
jwrosewell wants to merge 1 commit into
Draft
jwrosewell wants to merge 1 commit into
jwrosewell wants to merge 1 commit into
Conversation
The fresh-clone workflow built only the console examples, with their tests compiled. A web example test that used a class the published packages lack would not have failed it. The Ubuntu job now builds every example module with its tests compiled, after it has saved the data file for the other systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Since #175, the tests in
examples/device-detectionimportedTestFileUtilsandTestKeyUtilsfrom device-detection.shared'ssrc/test. A fresh clone builds the examples against the published packages, whose 4.5.130 tests jar has neither class, somvn -pl console -am package -DskipTestsinexamples/device-detectionfailed atGettingStartedOnPremTest.java:[26,51]. #187 (343baac) fixed that build, and rc passes from a fresh clone. Nothing stops the same failure coming back.The change
f17fd53 adds a step to the Examples from a fresh clone workflow (
.github/workflows/examples-fresh-clone.yml). On Ubuntu it builds every example module, the web examples too, with its tests compiled, against only the published packages, so a test that uses a class the published packages lack fails there. It runs after the asset cache is saved, so the other systems still get the data file, and it does not run the tests, which the pull request build runs.AGENTS.mddescribes the new step.The step that runs
ci/run-fresh-clone-example.ps1is a pwsh step, so-ExpectDownload $truearrives as a boolean. Calling the script by hand withpwsh -Filepasses every value as a string, which the script rejects, so call it withpwsh -Commandwhen running it locally.The runs
GettingStartedOnPremTest.java:[26,51] cannot find symbol, so the new step does not run there. The new step widens what the workflow builds, to every example module with its tests.ci/run-fresh-clone-example.ps1pass for both products at f17fd53 and at rc 81e3d4a, and every com.51degrees artifact resolved at 4.5.130. At 20f9089 the device-detection build fails atGettingStartedOnPremTest.java:[26,51], and ManualDataUpdateTest, MetadataOnPremTest and OfflineProcessingTest fail the same way.What remains
The full build above.
Before you upgrade
Nothing changes in the packages. This adds a CI step only.