Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
b78810f
Point AGENTS.md at the one list of environment variable names (#118)
jwrosewell Nov 13, 2026
30e4886
Measure the share usage overhead as a median over warmed up rounds (#91)
jwrosewell Nov 13, 2026
0122ad7
Test that a header no element reads reaches the usage sharing message…
jwrosewell Nov 14, 2026
2aae801
Write the JSON Builder's errors as a list of messages (#128)
jwrosewell Nov 14, 2026
6e03a25
Name the builder defaults that were literals (#130)
jwrosewell Nov 14, 2026
cd5f5a4
Package descriptions use the words people search for, and source link…
jwrosewell Nov 14, 2026
c5d4559
Start Chrome once before the Selenium contract tests (#124)
jwrosewell Nov 14, 2026
ceab088
Build each pull request on the configurations its changes need (#43)
jwrosewell Nov 14, 2026
fb2cb84
Give each package its own version and release only what changed (#63)
jwrosewell Nov 14, 2026
b76596b
Compare usage sharing keys in the root locale (#83)
jwrosewell Nov 14, 2026
1c99b72
Point configuration page links at 51degrees.com/configure (#115)
jwrosewell Nov 14, 2026
23e0fc6
Test the repeat rule in one session, and the values added beside the …
jwrosewell Nov 14, 2026
b33daa0
Run one Chrome driver session before the Selenium contract tests (#138)
jwrosewell Nov 14, 2026
20cadd0
Name the properties wanted on the cloud Pipeline builders, and test a…
jwrosewell Nov 14, 2026
32b3784
Share a header named Cookies by default, as only the Cookie header is…
jwrosewell Nov 14, 2026
4de92f6
Cache the client-side endpoints' answers as the specification and RFC…
jwrosewell Nov 15, 2026
80ff50f
Log a data update download cut short, and every other HTTP failure, a…
jwrosewell Nov 15, 2026
4985c27
End every Device Detection and IP Intelligence example with a Find ou…
jwrosewell Nov 15, 2026
fcde776
End every Pipeline developer and Location console example with a Find…
jwrosewell Nov 15, 2026
de74c8c
Supply server.request-query in the web integration (#144)
jwrosewell Nov 15, 2026
2eebbff
Write a no-value Property as null in the JSON, and refuse a bad proto…
jwrosewell Nov 15, 2026
67a4e56
Compare 51Did factor words ignoring case, and name the version of a s…
jwrosewell Nov 15, 2026
30e8df6
Build and run the examples from a fresh clone on the runner's own JDK…
jwrosewell Nov 15, 2026
206e9e9
Test the positions of the elements the web integration adds (#155)
jwrosewell Nov 15, 2026
50e63e4
Test that FodId keeps the byte layout, the payload version and its co…
jwrosewell Nov 15, 2026
8e53055
Say at start-up what the Enterprise data file adds in the IP Intellig…
jwrosewell Nov 15, 2026
c2d982a
Keep the configured interval test's update check from running before …
jwrosewell Nov 15, 2026
4e537d3
Throw for a cloud property the response leaves out, as Location does …
jwrosewell Nov 15, 2026
8e4244e
Write the usage sharing record as the specification's Processing sect…
jwrosewell Nov 15, 2026
e2472ee
Stop sending usage data and discard the rest when closing has waited …
jwrosewell Nov 15, 2026
ebaf75b
Say in AGENTS.md that a test failing on timing is fixed (#122)
jwrosewell Nov 16, 2026
20f9089
Specification conformance, 51degrees-java, section 15 (#175)
jwrosewell Nov 16, 2026
343baac
Build the Device Detection example tests from a fresh clone (#187)
jwrosewell Nov 16, 2026
402ab9c
Run the usage sharing builder tests, which JUnit 5 passed over (#142)
jwrosewell Nov 16, 2026
81e3d4a
Describe the examples as they run today in AGENTS.md and the example …
jwrosewell Nov 16, 2026
6d4454c
Read cloud Device Detection values when the Property metadata is empt…
jwrosewell Nov 16, 2026
820a544
Minify the JavaScript with a third-party library, and test the JSON e…
jwrosewell Nov 16, 2026
e2d9a01
Share every query value by default, and no cookie but 51D_ ones even …
jwrosewell Nov 16, 2026
933e424
Lock every read of IP Intelligence native results, type Latitude and …
jwrosewell Nov 16, 2026
c54795a
Log the data update errors table's rows as the specification gives th…
jwrosewell Nov 16, 2026
fd2bda3
Split a property list given as one string at every comma (#166)
jwrosewell Nov 16, 2026
46115d7
Find Element Data by its key whatever the case (#167)
jwrosewell Nov 16, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/ci-script-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: CI script tests

# Runs the Pester tests of the scripts in ci on Linux and Windows, where the
# builds run them. The environment variable names workflow runs its own test.

on:
pull_request:
paths:
- 'ci/**'
- '.github/workflows/ci-script-tests.yml'
push:
branches:
- main
- rc
paths:
- 'ci/**'
- '.github/workflows/ci-script-tests.yml'
workflow_dispatch:

permissions:
contents: read

jobs:
ci-script-tests:
name: Test the CI scripts on ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Run the tests
shell: pwsh
run: |
$tests = Get-ChildItem ./ci -Filter *.Tests.ps1 |
Where-Object Name -ne 'check-environment-variable-names.Tests.ps1'
Invoke-Pester -Path $tests.FullName -CI -Output Detailed
16 changes: 12 additions & 4 deletions .github/workflows/cloud-51did.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ name: Cloud 51Did Tests
# the cloud for a 51Did and fail, saying so, when a key gets an answer with no
# identifier in it. That is entitlement working rather than a fault.
#
# A run that has a license key also runs the Cloud Request Engine's live test
# on a license key alone (pipeline/pipeline.cloudrequestengine,
# CloudRequestEngineLiveTests), because no other workflow has a license key
# for the cloud service. Without one that test skips.
#
# The secrets are named one by one rather than passed as toJSON(secrets).
# GitHub marks a workflow that hands every secret to a step as possibly
# malicious and holds each run for manual approval, so the nightly never ran.
Expand All @@ -29,9 +34,10 @@ on:
schedule:
- cron: '10 5 * * *'
pull_request:
branches: [main]
branches: [main, rc]
paths:
- 'pipeline/pipeline.did/**'
- 'pipeline/pipeline.cloudrequestengine/**'
- 'pipeline/owid-java/**'
- '.github/workflows/cloud-51did.yml'

Expand Down Expand Up @@ -73,7 +79,7 @@ jobs:
}
$failed = $false
foreach ($k in $keys) {
Write-Host "::group::DidClientLiveTests with $($k.Name)"
Write-Host "::group::Live tests with $($k.Name)"
$env:_51DEGREES_RESOURCE_KEY = $k.Value
$licenseName = $k.Name -replace '^_51DEGREES_RESOURCE_KEY', '_51DEGREES_LICENSE_KEY'
$license = [Environment]::GetEnvironmentVariable($licenseName)
Expand All @@ -85,8 +91,10 @@ jobs:
Remove-Item Env:_51DEGREES_LICENSE_KEY -ErrorAction SilentlyContinue
}
# Only the Pipeline API tree is built, as in its own repository.
mvn -B -f pipeline/pom.xml -pl pipeline.did -am test `
-Dtest=DidClientLiveTests -DfailIfNoTests=false
mvn -B -f pipeline/pom.xml `
-pl pipeline.did,pipeline.cloudrequestengine -am test `
'-Dtest=DidClientLiveTests,CloudRequestEngineLiveTests#build_Process_LicenseKeyAlone*' `
-DfailIfNoTests=false
if ($LASTEXITCODE -ne 0) { $failed = $true }
Write-Host '::endgroup::'
}
Expand Down
124 changes: 124 additions & 0 deletions .github/workflows/examples-fresh-clone.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
name: Examples from a fresh clone

# Builds each product's console examples as AGENTS.md says, from a clone
# with its submodules, against the packages published on Maven Central, with
# the JDK and Maven the runner has. Then runs the getting started example
# from the repository root with no settings. A fresh clone holds only a link
# for each free data file. On Ubuntu the example downloads its file, which
# tests the download, and the job keeps the file in the cache. The other
# systems take it from there, so each file is downloaded once a run.

on:
pull_request:
paths:
- 'examples/**'
- 'cxx'
- '.github/workflows/examples-fresh-clone.yml'
- 'ci/run-fresh-clone-example.ps1'
push:
branches:
- main
- rc
schedule:
- cron: '30 4 * * *'
workflow_dispatch:

permissions:
contents: read

jobs:
download:
name: ${{ matrix.product }} on ubuntu-latest, downloading its data file
strategy:
fail-fast: false
matrix:
include:
- product: device-detection
example: fiftyone.devicedetection.examples.console.GettingStartedOnPrem
file: cxx/data/device-detection/51Degrees-LiteV4.1.hash
- product: ip-intelligence
example: fiftyone.ipintelligence.examples.console.GettingStartedOnPrem
file: cxx/data/ip-intelligence/51Degrees-LiteV41.ipi
runs-on: ubuntu-latest
steps:
- name: Clone the repository with its submodules
uses: actions/checkout@v4
with:
submodules: recursive
persist-credentials: false

- name: The runner's Java and Maven
shell: pwsh
run: |
java -version
mvn -v

- name: Build the console examples against the published packages
working-directory: examples/${{ matrix.product }}
shell: pwsh
run: mvn -B --no-transfer-progress -pl console -am package -DskipTests

- name: Run the getting started example from the repository root
shell: pwsh
run: >-
./ci/run-fresh-clone-example.ps1 -Product '${{ matrix.product }}'
-Example '${{ matrix.example }}' -ExpectDownload $true

# The key follows the link, so a new free file gets a new entry, and
# the same file is kept once rather than once a run.
- name: Keep the data file for the other systems
uses: actions/cache/save@v4
with:
path: ${{ matrix.file }}
key: fresh-clone-${{ matrix.product }}-${{ hashFiles(format('{0}.link', matrix.file)) }}
enableCrossOsArchive: true

other-systems:
name: ${{ matrix.product }} on ${{ matrix.os }}
needs: download
strategy:
fail-fast: false
matrix:
# macOS runners are shared by the whole organisation, so pull
# requests leave them out and the pushes and the daily run use them.
os: ${{ fromJSON(github.event_name == 'pull_request' && '["windows-latest"]' || '["windows-latest", "macos-latest"]') }}
product: [device-detection, ip-intelligence]
include:
- product: device-detection
example: fiftyone.devicedetection.examples.console.GettingStartedOnPrem
file: cxx/data/device-detection/51Degrees-LiteV4.1.hash
- product: ip-intelligence
example: fiftyone.ipintelligence.examples.console.GettingStartedOnPrem
file: cxx/data/ip-intelligence/51Degrees-LiteV41.ipi
runs-on: ${{ matrix.os }}
steps:
- name: Clone the repository with its submodules
uses: actions/checkout@v4
with:
submodules: recursive
persist-credentials: false

- name: Take the data file the Ubuntu job downloaded
uses: actions/cache/restore@v4
with:
path: ${{ matrix.file }}
key: fresh-clone-${{ matrix.product }}-${{ hashFiles(format('{0}.link', matrix.file)) }}
enableCrossOsArchive: true
fail-on-cache-miss: true

- name: The runner's Java and Maven
shell: pwsh
run: |
java -version
mvn -v

- name: Build the console examples against the published packages
working-directory: examples/${{ matrix.product }}
shell: pwsh
run: mvn -B --no-transfer-progress -pl console -am package -DskipTests

- name: Run the getting started example from the repository root
shell: pwsh
run: >-
./ci/run-fresh-clone-example.ps1 -Product '${{ matrix.product }}'
-Example '${{ matrix.example }}' -ExpectDownload $false
62 changes: 32 additions & 30 deletions .github/workflows/nightly-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,35 @@ on:
- cron: '0 3 * * *'

jobs:
# The publish builds main, which the pull requests into rc do not change, so
# it runs first and has the runners before the pull request builds do.
Publish:
name: Nightly Publish
uses: 51Degrees/common-ci/.github/workflows/nightly-publish.yml@main
with:
repo-name: ${{ github.event.repository.name }}
org-name: ${{ github.event.repository.owner.login }}
dryrun: ${{ inputs.dryrun || false }}
common-ci-ref: ${{ inputs.common-ci-ref || '' }}
cache-assets: true
secrets:
token: ${{ secrets.ACCESS_TOKEN }}
DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
DeviceDetectionUrl: ${{ secrets.DEVICE_DETECTION_URL }}
IpIntelligence: ${{ secrets.IP_INTELLIGENCE_KEY }}
IpIntelligenceUrl: ${{ secrets.IPI_DATA_FILE_URL }}
TestResourceKey: ${{ secrets._51DEGREES_RESOURCE_KEY_BESPOKE }}
MavenSettings: ${{ secrets.MAVEN_SETTINGS }}
JavaGpgKeyPassphrase: ${{ secrets.JAVA_GPG_KEY_PASSPHRASE }}
JavaPGP: ${{ secrets.JAVA_KEY_PGP_FILE }}
CodeSigningKeyVaultName: ${{ secrets.CODE_SIGNING_KEY_VAULT_NAME }}
CodeSigningKeyVaultUrl: ${{ secrets.CODE_SIGNING_KEY_VAULT_URL }}
CodeSigningKeyVaultClientId: ${{ secrets.CODE_SIGNING_KEY_VAULT_CLIENT_ID }}
CodeSigningKeyVaultTenantId: ${{ secrets.CODE_SIGNING_KEY_VAULT_TENANT_ID }}
CodeSigningKeyVaultClientSecret: ${{ secrets.CODE_SIGNING_KEY_VAULT_CLIENT_SECRET }}
CodeSigningKeyVaultCertificateName: ${{ secrets.CODE_SIGNING_KEY_VAULT_CERTIFICATE_NAME }}
CodeSigningKeyVaultCertificateData: ${{ secrets.CODE_SIGNING_KEY_VAULT_CERTIFICATE_DATA }}

DataFileChange:
name: Nightly Data File Change
uses: 51Degrees/common-ci/.github/workflows/nightly-data-file-change.yml@main
Expand Down Expand Up @@ -50,7 +79,7 @@ jobs:

PullRequests:
if: ${{ !cancelled() }}
needs: [DataFileChange, PackageUpdate, SubmoduleUpdate]
needs: [Publish, DataFileChange, PackageUpdate, SubmoduleUpdate]
name: Nightly Pull Requests
uses: 51Degrees/common-ci/.github/workflows/nightly-pull-requests.yml@main
with:
Expand All @@ -59,39 +88,12 @@ jobs:
dryrun: ${{ inputs.dryrun || false }}
common-ci-ref: ${{ inputs.common-ci-ref || '' }}
cache-assets: true
# One configuration that fails does not cancel the others.
fail-fast: false
secrets:
token: ${{ secrets.ACCESS_TOKEN }}
DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
DeviceDetectionUrl: ${{ secrets.DEVICE_DETECTION_URL }}
IpIntelligence: ${{ secrets.IP_INTELLIGENCE_KEY }}
IpIntelligenceUrl: ${{ secrets.IPI_DATA_FILE_URL }}
TestResourceKey: ${{ secrets._51DEGREES_RESOURCE_KEY_BESPOKE }}

Publish:
if: ${{ !cancelled() }}
needs: PullRequests
name: Nightly Publish
uses: 51Degrees/common-ci/.github/workflows/nightly-publish.yml@main
with:
repo-name: ${{ github.event.repository.name }}
org-name: ${{ github.event.repository.owner.login }}
dryrun: ${{ inputs.dryrun || false }}
common-ci-ref: ${{ inputs.common-ci-ref || '' }}
cache-assets: true
secrets:
token: ${{ secrets.ACCESS_TOKEN }}
DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
DeviceDetectionUrl: ${{ secrets.DEVICE_DETECTION_URL }}
IpIntelligence: ${{ secrets.IP_INTELLIGENCE_KEY }}
IpIntelligenceUrl: ${{ secrets.IPI_DATA_FILE_URL }}
TestResourceKey: ${{ secrets._51DEGREES_RESOURCE_KEY_BESPOKE }}
MavenSettings: ${{ secrets.MAVEN_SETTINGS }}
JavaGpgKeyPassphrase: ${{ secrets.JAVA_GPG_KEY_PASSPHRASE }}
JavaPGP: ${{ secrets.JAVA_KEY_PGP_FILE }}
CodeSigningKeyVaultName: ${{ secrets.CODE_SIGNING_KEY_VAULT_NAME }}
CodeSigningKeyVaultUrl: ${{ secrets.CODE_SIGNING_KEY_VAULT_URL }}
CodeSigningKeyVaultClientId: ${{ secrets.CODE_SIGNING_KEY_VAULT_CLIENT_ID }}
CodeSigningKeyVaultTenantId: ${{ secrets.CODE_SIGNING_KEY_VAULT_TENANT_ID }}
CodeSigningKeyVaultClientSecret: ${{ secrets.CODE_SIGNING_KEY_VAULT_CLIENT_SECRET }}
CodeSigningKeyVaultCertificateName: ${{ secrets.CODE_SIGNING_KEY_VAULT_CERTIFICATE_NAME }}
CodeSigningKeyVaultCertificateData: ${{ secrets.CODE_SIGNING_KEY_VAULT_CERTIFICATE_DATA }}
10 changes: 10 additions & 0 deletions .github/workflows/pull-requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
common-ci-ref:
type: string
default: ''
full-matrix:
description: 'Build every configuration, not only those the changes need'
type: boolean
default: false

jobs:
PullRequests:
Expand All @@ -20,6 +24,12 @@ jobs:
dryrun: ${{ inputs.dryrun || false }}
common-ci-ref: ${{ inputs.common-ci-ref || '' }}
cache-assets: true
# Each pull request is built on the configurations its changes need,
# as ci/select-options.ps1 chooses, and one that fails does not cancel
# the others. With nothing eligible, the nightly builds rc instead.
full-matrix: ${{ inputs.full-matrix || false }}
fail-fast: false
build-without-pull-requests: false
secrets:
token: ${{ secrets.ACCESS_TOKEN }}
DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
Expand Down
31 changes: 31 additions & 0 deletions .github/workflows/release-pull-request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Release Pull Request

# Builds and tests the release pull request, rc into main, on every entry in
# ci/options.json, and never merges it. A pull request into rc is built only on
# the entries its changes need, so this is the full build of a release before
# it reaches main. See common-ci .github/workflows/release-pull-request.yml.
on:
pull_request:
branches: [main]

# A push to rc while the release is open builds it again, in place of the
# build of the older rc.
concurrency:
group: release-pull-request-${{ github.event.pull_request.number }}
cancel-in-progress: true

jobs:
Release:
name: Release Pull Request
uses: 51Degrees/common-ci/.github/workflows/release-pull-request.yml@main
with:
repo-name: ${{ github.event.repository.name }}
org-name: ${{ github.event.repository.owner.login }}
cache-assets: true
secrets:
token: ${{ secrets.ACCESS_TOKEN }}
DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
DeviceDetectionUrl: ${{ secrets.DEVICE_DETECTION_URL }}
IpIntelligence: ${{ secrets.IP_INTELLIGENCE_KEY }}
IpIntelligenceUrl: ${{ secrets.IPI_DATA_FILE_URL }}
TestResourceKey: ${{ secrets._51DEGREES_RESOURCE_KEY_BESPOKE }}
Loading
Loading