Skip to content

Say in AGENTS.md that a test failing on timing is fixed - #122

Merged
jwrosewell merged 2 commits into
rcfrom
docs/timing-tests-rule
Nov 16, 2026
Merged

jwrosewell merged 2 commits into
rcfrom
docs/timing-tests-rule

Conversation

@jwrosewell

@jwrosewell jwrosewell commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Tests that fail on a time limit, a performance threshold or a timeout, and pass when run again, keep coming back at random, and each time someone has to look into the failure before running it again. AGENTS.md says nothing about them, so a contributor who meets one runs it again.

What changed

AGENTS.md gains a short section, "Tests that fail on timing", which says such a test is fixed, either with a limit that fits the slowest runner it runs on, with each runner's measurement behind it, or by finding and fixing why it takes too long. Nothing else changes.

Checks

This changes documentation only and no package code, so it merges on its quick checks and a review, without a full build. The release #112 it was waiting for merged into main on 13 November. rc was merged in at ee74906, bringing #118 and #91, without conflict.

@jwrosewell jwrosewell mentioned this pull request Nov 13, 2026
jwrosewell added a commit that referenced this pull request Nov 15, 2026
…its verify (#161)

Tests only. `DataUpdateServiceTests.DataUpdateService_Register_AutoUpdateConfiguredInterval` fails about once in 600 runs, and it failed `Ubuntu_Java_17` in full build [43667464820](https://github.com/51Degrees/51degrees-java/actions/runs/43667464820) of [#156](#156), which changes nothing in `pipeline.engines`. This fixes the cause rather than leaving it to a re-run, which is the rule for a test that fails on timing. [#122](#122), which is open and not yet merged, adds that rule to AGENTS.md.
@jwrosewell
jwrosewell marked this pull request as ready for review November 16, 2026 00:05
@jwrosewell
jwrosewell merged commit ebaf75b into rc Nov 16, 2026
3 checks passed
@jwrosewell
jwrosewell deleted the docs/timing-tests-rule branch November 16, 2026 00:05
@jwrosewell jwrosewell mentioned this pull request Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant