Skip to content

Keep test utility classes out of the published pipeline and IP Intelligence jars #182

Open

Description

@jwrosewell

Problem

#175 moves the Device Detection test utility classes FileUtils and KeyUtils out of use in device-detection.shared's main jar, keeping them there deprecated, and its PublishedPackageTests checks the Device Detection modules. Other published modules still carry tests or test helpers.

  1. device-detection.shared, pipeline.common, pipeline.engines and ip-intelligence.shared publish a -tests.jar.
  2. pipeline.common and ip-intelligence.shared keep test utility classes in their main jars, for example ip-intelligence.shared's testhelpers.FileUtils.
  3. FileUtils and KeyUtils stay in device-detection.shared's main jar, deprecated, until a release may remove them.

What the specification says

device-detection-specification/packaging-and-structure.md line 16 at dbaf099c:

Examples and tests SHOULD NOT be included in any published packages.

The sentence is in the Device Detection specification, so how far it reaches beyond Device Detection is open.

Suggested work

Once that is settled, extend PublishedPackageTests to each module it covers first, then move those classes into the test sources, keeping any public class in the main jar deprecated for at least one release.

Activity

  1. changed the title [-]Keep test helpers out of the published pipeline and IP Intelligence jars[/-] [+]Keep test utility classes out of the published pipeline and IP Intelligence jars[/+] on Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions