test(ipc): Drop wall-clock timing from the daemon start test - #107
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



tests/ipc-daemon-start.test.tschecked thatensureDaemonStartedresolves within 50 ms of the socket accepting connections, using real sockets and wall-clock time. The code polls every 25 ms, so a loaded runner blows the budget while the code is correct: on #106 it failed on Node 26 withexpected 238 to be less than or equal to 50, and passed on Node 24 in the same run.The test now runs on fake timers with
fs.existsSyncandnet.createConnectionstubbed. The first probe fails, the daemon is spawned once, readiness flips, and the call has to settle within 50 fake ms. Nothing insrc/daemon/ipc.tschanges.Tests
npx vitest run tests/ipc-daemon-start.test.ts: 3 passed, five runs in a rowsrc/daemon/ipc.ts, all killed: poll interval raised to 51 ms, raised to 100 ms, readiness result ignored