fix(open): Hold the injected rename until the input box is empty - #105
Merged
Merged
Conversation
Queue the sidecar name while the input line is dirty, then type it after Enter and 300 ms of quiet. Cover the input gate, TUI wiring, and safety cases. Co-Authored-By: Codex <noreply@openai.com>
Alt+Enter arrives as ESC CR and inserts a newline in Claude Code, so it must not release a held rename. A lone ESC before a bracketed paste no longer hides the paste start. Tighten the dispose and wiring tests so each proves its rule.
Track the current token so mention acceptance keeps the input dirty, then let a later submit release the held rename. Handle backspaces and uncertain edits conservatively while preserving the existing submit rules. Co-Authored-By: Codex <noreply@openai.com>
Claude Code queries the terminal at startup and the DCS, DA1 and DECRPM replies came through the gate as unknown escapes, so the rename waited for the second prompt. Whole-chunk terminal replies are now ignored like focus reports. Measured on Claude Code 2.1.280: Enter with the @ menu open submits, and only arrow navigation plus Enter accepts a suggestion without submitting. The escape guard covers that path, so the token tracking is gone.
A lazy DCS or OSC body could run past the reply terminator and swallow a chunk that also held typed text. Bodies now stop at ESC or BEL, and a test pins that mixed chunks still dirty the box. The pattern needs control characters, so the Sonar control character rule is silenced on that line.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codedeck opentypes/rename <name>+ Enter into the pty as soon as the title hook writes its sidecar. The title comes from a Haiku call that takes a few seconds, so it usually lands while the user is typing the second message. Claude Code appends it to the half-typed line and the Enter submits both:Bora tamb/rename XPto xyzwent out as one prompt.The wrapper already sees every keystroke, so
startPtySessionnow routes them throughcreateInputGate(src/open/pty.ts). The rename is typed only when the box is clean (nothing typed since the last Enter, or since the session started) and there has been no key for 300 ms. If the user is mid-line, the name is held and typed after their next submit plus 300 ms of quiet, and it then runs as a queued slash command, asdocs/harness-behaviour.mddescribes.A
\rdoes not count as a submit when it is inside a bracketed paste, after\(line continuation), or afterESC(Alt/Option+Enter). An Enter that follows an unrecognised escape sequence (arrows, CSI-u keys) or an unknown control byte does not count either: measured on Claude Code 2.1.280, Down then Enter accepts an@suggestion without submitting, while Enter with the menu open and no navigation submits the prompt as typed.Chunks that are only terminal replies (DCS, OSC, CSI replies with a
?or>prefix) are ignored like focus reports. Claude queries the terminal at startup, and without this the replies armed the escape guard and pushed the rename to the second prompt.The rename is typed at most once, and a held name is dropped on dispose. Every uncertain case (Ctrl+C, a lone Esc, arrow navigation) keeps the name held, so the worst case is a rename that lands one prompt later.
Spec:
.specs/features/pty-session-rename/spec.md, Block B.Not covered: measurements were taken in tmux only, not through the real
codedeck openpath (scripts/rename-gate.shwas not rerun), and other terminals' startup replies were not captured. A terminal that answers with a reply this pattern does not know falls on the escape guard, which only delays the rename.Tests
npx vitest run tests/open-pty.test.ts: 65 passednpx vitest run tests/open-: 8 files, 302 passed (at 59b7b46)npx tsc --noEmit -p .: cleannpm run build && scripts/pty-gate.sh:pty path ok: tty, 137x41, /rename corrigir-auth-do-login typed, keys still flowing(run on the first commit)\rinside a paste as submit, releasing on submit without the quiet window, typing the rename twice, dropping the\continuation check, dropping theESC(Alt+Enter) check, removing the terminal reply skip (7 tests fail), not guarding Enter after an unknown escape (Down+Enter test fails), restoring the lazy DCS body (mixed-chunk test fails).