feat(sms): support optional account for volcengine multi-account#128
Merged
Conversation
Allow callers to pass SmsAccount per request; fall back to VOLCENGINE_SMS_ACCOUNT when omitted. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
sdk version 2.27.1-pr-128-ef6200b85a ## for js/ts project
pnpm add @36node/auth-sdk@2.27.1-pr-128-ef6200b85a |
Use resolveAccount when creating records so env fallback is stored. Co-authored-by: Cursor <cursoragent@cursor.com>
tylor-zhang
pushed a commit
that referenced
this pull request
Jun 15, 2026
🤖 I have created a release *beep* *boop* --- ## [2.28.0](v2.27.1...v2.28.0) (2026-06-15) ### Features * **sms:** support optional account for volcengine multi-account ([#128](#128)) ([18217cb](18217cb)) ### Bug Fixes * allow legacy weak old password when updating password ([#126](#126)) ([f4d819f](f4d819f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accountfield toSendSmsDtofor Volcengine SmsAccount (消息组 ID)SmsServiceusesdto.account ?? VOLCENGINE_SMS_ACCOUNTwhen sending via volcengineaccountonSmsRecordfor auditTest plan
sms.service.spec.ts(dto account vs env fallback)Made with Cursor