Repository navigation
[G01] Account workflow provenance GET lifecycle - #161
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
a1181bf to
85baf46
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fixes #160
Summary
TDD and verification
a4d6f03b81cbc77f51bf9eb0d37fdf47d67c02f3: workflow-GET lost-response replay completed inspect and minted twice; repeated on a fresh archive of that base.b9ca7c96c7881391a1cc9ed6f06b6a7848e9f1b4with a test-only overlay: independent mutations of attempt, journal, controller-approval digest, source, workflow run ID, ref, SHA and path each let inspect complete and mint twice. A slot mismatch failed closed, and the matching-history control passed.TestBrokerExperimentV3HistoricalWorkflowProvenanceClaimReplayBindingpasses undergo test -race -count=1 -timeout=180s -run '^TestBrokerExperimentV3HistoricalWorkflowProvenanceClaimReplayBinding$' -v .(all nine mismatch cases plus the named matching-history control, 7.673s).eefe8dfde5134b014b54ca45277640c6401c0395, focused verification, full G02go test -race -p=1 -count=1 -timeout=300s ./...(all packages; root 143.977s), andgo vet -p=1 ./...passed. The test-only follow-up was rerun with the focused race selector above.git diff --checkpassed. Go 1.27.3 was used with downloads disabled and caches/temp on external storage.Candidate and review state
a1181bff77027cb436ba9fc8bb1c3dfe5bb60051(documentation-only update after the test candidate).f0b4e97d323a0dc637dfe6cff9c74fa62ca1d922passed hosted Go checks and exact-head GitHub Codex review with no major findings. Independent Luna Max confirmed the replay-binding P2 was resolved and found no remaining source P0/P1/P2 issue; it held overall because evidence wording still described that pushed candidate as local/pending. Commita1181bflabels earlier pending states as historical and records the then-current review status.a1181bff77027cb436ba9fc8bb1c3dfe5bb60051; GitHub Codex completed review of that exact head with no findings, and independent Luna Max reviewed the same SHA and returned APPROVE with no P0-P3 findings.No provider credentials, tokens, workflow dispatch, runner, Scale Set, Docker, host-service or canary operation was performed. Issue #160 and parent issue #1 remain OPEN; Project #2 remains In progress while G01 live and production qualification gates remain unresolved.