Repository navigation
[G01] Revoke read-only broker token after preflight - #159
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Independent review triage — exact head
|
Related to #1. This PR does not close G01.
Change
Review triage
Independent Luna Max review of prior head
7a5c6e2a57de2015cd2d540194ddad49a83a24a9approved the bounded offline/static change, found no P0/P1 defects, and held all live gates. Its two P2 evidence gaps—full-path revoked-record sync fault injection and exact DELETE counts—were addressed in8bbf43ead63bdcfce8615a87c4038d84db30f6ed. Follow-up review at8bbf43efound a P2 test-seam concurrency risk from a mutable package-global opener. Commit1ea35587f5df5fa6b7c1b5c34bc87689a8a02061replaces it with per-execution context-scoped fault injection; production contexts carry no hook and use the canonical opener. A separate independent Luna Max review of prior exact headd8f387fdc7e367ac65e23a3b449ee7202aff2163returned HOLD: P1 because caller-token equality was checked only after DELETE (broker.go:308,312-321); P1 because a valid token returned with rejected scope/expiry could be discarded before cleanup (broker_api.go:231-235,broker.go:301-304); and P2 because a successful DELETE followed by journal append/sync failure had no durable uncertainty marker (broker.go:321). The remediation is present in candidate commits4f3d84f,8bbf43eand1ea3558, including full-path fault coverage, exact DELETE counts and per-execution fault-hook scope. A fresh Luna Max review of exact head1ea35587f5df5fa6b7c1b5c34bc87689a8a02061, including the open live-harness checklist, has been queued; its verdict is pending. The documentation caveat remains deliberate: source-level evidence is plan-only and runtime, trust-root, conditional-delete and live gates stay open.GitHub Codex reviewed prior exact head
8bbf43ead63bdcfce8615a87c4038d84db30f6edon 2026-11-03 with no major issues (review receipt comment); that review predates the context-scoped test-hook fix. Codex then completed review of exact current head1ea35587f5df5fa6b7c1b5c34bc87689a8a02061on 2026-11-03 with no findings (review status). The fresh exact-head Luna Max review and live-harness checklist review are queued and pending.Verification
Go 1.27.3 was used with Go caches and temporary build files on
/Volumes/worktree.On current candidate
1ea35587f5df5fa6b7c1b5c34bc87689a8a02061:go vet ./...— PASS.cmd/g01-livetagged tests — PASS on prior candidate8bbf43e; this commit did not change the G01 module.cmd/g01-livetagged vet — PASS on prior candidate8bbf43e; this commit did not change the G01 module.go vet -tags=g01_live ./...— PASS.git diff --check— PASS.go test -tags=g01_live -count=1 -timeout=120s ./...— TIMED OUT inscripts.TestToolingTaggedPairFixturePartitionsRun. An isolated run of that test with a 180s limit also timed out while it invoked the offline partition matrix. These are inconclusive, not passes; no test processes remained afterward.4f3d84f52402f21ec5b1031a19af92aaeb60b424; those results are retained at that immutable SHA.The hosted Go check passed for current exact head
1ea35587f5df5fa6b7c1b5c34bc87689a8a02061(run 41646883014). The prior candidate check also passed at8bbf43ead63bdcfce8615a87c4038d84db30f6ed(run 41645907149). All token/provider interactions in these tests use synthetic fixtures. No real GitHub token was minted or revoked, and no provider, runner, Scale Set or host operation was performed.Remaining G01 gates
This does not solve the management-token lifetime or non-atomic provider-read/handoff race. Authenticated provenance and trust-root custody, broker-only execution authority, trusted runtime/isolation and resource qualification, supported server-side conditional Scale Set deletion, and the separately authorized live Linux ARM64/JIT canary remain open. Issue #1 stays OPEN and Project #2 stays In progress.
Current candidate update — 2026-11-03 (
a35220b089d3a3bd79ab1575620892f138739a42)The latest offline fix closes the compound revocation-journal failure identified by the prior Luna Max review. Before read-token DELETE, the broker now syncs an account-ledger intent bound to phase, attempt inode and journal inode; it records confirmation only after DELETE succeeds and the per-attempt success record is durable. An unmatched intent blocks every later phase, including inspect and cleanup, before management-token issuance or handoff. A regression at prior head
1ea3558reproduced the gap; the corrected full-path fixture now proves the later inspect is refused with zero token mints.go test -count=1 -timeout=120s ./...— PASS (all packages).go vet ./...— PASS.git diff --check— PASS.No live token, provider, runner, Scale Set, Docker or host operation occurred. Issue #1 remains OPEN and Project #2 remains In progress; production provenance, trust-root custody, broker-only execution, read-to-handoff race, management-token expiry/revocation, supported conditional Scale Set deletion, trusted runtime/isolation/resource qualification, live readiness and the separately authorized canary remain open.
Review status update — 2026-11-03
For exact head
a35220b089d3a3bd79ab1575620892f138739a42, hosted Go checks passed (run 41652104987) and the GitHub Codex review completed with no findings. The independent Luna Max review was dispatched against this exact worktree; no final Orca result has arrived yet. PR remains open until that review is resolved and triaged. Issue #1 remains OPEN / Project #2 In progress; the live G01 gates listed above remain open.Current candidate update — 2026-11-03 (
efa05d8fb142a687fa58264ba119fef1558a33c7)The independent Luna Max review at prior head
a35220b089d3a3bd79ab1575620892f138739a42found a P1: the account ledger recorded read-token revocation intent only after a usable response existed. If GitHub accepted the token POST and its response was lost, no token candidate or account barrier remained, so a laterinspectcould mint management authority. The RED regression reproduced that sequence on the prior head.The fix syncs
read_token_lifecycle_startedimmediately before the HTTP client dispatch. A lost response leaves the account-wide barrier pending. A failure before dispatch recordsread_token_request_not_dispatched; incomplete historical reusable-callee claims without lifecycle/no-dispatch proof fail closed. Correctly paired legacy revocation records remain compatible. The read-only mint helper now requires an explicit pre-request callback.Validation on
efa05d8Go 1.27.3;
GOCACHE,GOMODCACHEandTMPDIRwere on/Volumes/worktree.a35220b: accepted read-token POST with lost response, then inspect — FAIL as expected; no account intent, inspect completed and minted again.go test -race -count=1 -timeout=210s ./...— PASS (all packages; library 129.994s).go vet ./...— PASS.gofmt -lon changed Go files andgit diff --check— PASS.@codex reviewand independent Luna Max exact-head review — running/pending at this update.No provider token, runner, Scale Set, Docker or host operation was used. GitHub issue/PR/Project metadata reads used
gh. This PR does not close G01. Issue #1 remains OPEN and Project #2 In progress while production provenance/trust roots, management-token lifecycle, read-to-handoff race, conditional Scale Set deletion, trusted runtime/isolation/resource qualification, and separately authorized Linux ARM64/JIT canary evidence remain open.