Support localhost OAuth callback handoff for hosted browsers - #43
Draft
eladrave wants to merge 1 commit into
Draft
Support localhost OAuth callback handoff for hosted browsers#43eladrave wants to merge 1 commit into
eladrave wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell.openExternalforwarding for authorization linksWhy
Remote-control authorization uses a registered callback such as
http://localhost:1455/auth/callback. When codex-web runs on another machine,the user's browser is redirected to its own localhost rather than the machine
running the Codex listener, so authorization cannot complete.
For recognized remote-control authorization URLs, this change presents a
user-clicked authorization link and asks the user to paste the complete
localhost callback URL after OpenAI redirects. The callback then travels over
the existing browser IPC WebSocket and is forwarded internally to the
server-side loopback listener.
Security
/auth/callbackon ports 1455 and 1457 are acceptedstateand eithercodeorerrorValidation
npm cinpm testnpm run build:browsergit diff --check