fix(github): allow CONTRIBUTOR association by default - #21
Merged
Conversation
GitHub labels some write-access teammates as CONTRIBUTOR instead of MEMBER, so the payload gate skipped reviews before the live write check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTRIBUTORorFIRST_TIME_CONTRIBUTOR, notMEMBER.Why
Observed on OMSX: a teammate with repo write got
author association not allowed: CONTRIBUTORonpull_request, so automatic review never started.GitHub does this for private org membership, and some org-repo permission shapes. The live collaborator-permission check is the real security boundary.
NONEstill skips. Repos can still narrowallowed-associations.Test plan
pnpm exec vitest run tests/github-action.test.ts(45 passed)pnpm run typecheckCONTRIBUTORauthor with write gets a review after this ships to npm and consumers bump the action pinRisks / follow-ups
allowed-associations: OWNER,MEMBER,COLLABORATOR,CONTRIBUTOR,FIRST_TIME_CONTRIBUTOR.0xPolygon/codegenie@<sha>.