Repository navigation
Conversation
The single-argument PRINT macro in the %strlen section passed a label to %strlen. Since %strlen is evaluated by the preprocessor, it returned the length of the label name instead of the length of the data, so the macro printed only part of the message. Rework the macro to take a string literal, define it in the .data section under a macro-local label, and explain in the text why a label can't be used here. Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
1 task done
klaudiagrz
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The single-argument PRINT macro in the %strlen section passed a label to %strlen. Since %strlen is evaluated by the preprocessor, it returned the length of the label name instead of the length of the data, so the macro printed only part of the message.
Rework the macro to take a string literal, define it in the .data section under a macro-local label, and explain in the text why a label can't be used here.
Related issues
#98