diff --git a/server/pkg/task.go b/server/pkg/task.go index d030bdf..929c839 100644 --- a/server/pkg/task.go +++ b/server/pkg/task.go @@ -28,7 +28,7 @@ type Task struct { jobs []HostPort } -var valueRegexp = regexp.MustCompile(`^[a-z0-9]{1,30}$`) +var valueRegexp = regexp.MustCompile(`^[a-z0-9_]{1,30}$`) // Identifies task, for sorting and domain hash func (t *Task) ID() string { diff --git a/server/pkg/task_test.go b/server/pkg/task_test.go index e1f8313..aae4ce8 100644 --- a/server/pkg/task_test.go +++ b/server/pkg/task_test.go @@ -18,8 +18,8 @@ func TestValidateTask(t *testing.T) { task: Task{ operationID: "123", operationAlias: "alias", - taskName: "task", - service: "service", + taskName: "ta_sk", + service: "service_1", }, }, { @@ -30,27 +30,27 @@ func TestValidateTask(t *testing.T) { taskName: "task", service: "service", }, - err: errors.New("field \"operationAlias\" value \"ali-as\" does not match regexp \"^[a-z0-9]{1,30}$\""), + err: errors.New("field \"operationAlias\" value \"ali-as\" does not match regexp \"^[a-z0-9_]{1,30}$\""), }, { name: "invalid task name", task: Task{ operationID: "123", - operationAlias: "alias", + operationAlias: "_alias", taskName: "Task", service: "service", }, - err: errors.New("field \"taskName\" value \"Task\" does not match regexp \"^[a-z0-9]{1,30}$\""), + err: errors.New("field \"taskName\" value \"Task\" does not match regexp \"^[a-z0-9_]{1,30}$\""), }, { name: "invalid service", task: Task{ operationID: "123", operationAlias: "alias", - taskName: "task", + taskName: "ta_sk", service: "$ervice", }, - err: errors.New("field \"service\" value \"$ervice\" does not match regexp \"^[a-z0-9]{1,30}$\""), + err: errors.New("field \"service\" value \"$ervice\" does not match regexp \"^[a-z0-9_]{1,30}$\""), }, { name: "invalid service", @@ -60,7 +60,7 @@ func TestValidateTask(t *testing.T) { taskName: "task", service: "serviceserviceserviceserviceserviceserviceserviceservice", }, - err: errors.New("field \"service\" value \"serviceserviceserviceserviceserviceserviceserviceservice\" does not match regexp \"^[a-z0-9]{1,30}$\""), + err: errors.New("field \"service\" value \"serviceserviceserviceserviceserviceserviceserviceservice\" does not match regexp \"^[a-z0-9_]{1,30}$\""), }, { name: "do not check if no alias",