URI#encode deprecation#61
Open
ricvillagrana wants to merge 1 commit into
Open
Conversation
ricvillagrana
force-pushed
the
patch-1
branch
from
4c3936c to
b0718eb
Compare
|
Please include this fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57
URI, no longer supports
encode, so, I am updating it to an existing method (encode_www_form_component).Source: https://ruby-doc.org/stdlib-3.1.0/libdoc/uri/rdoc/URI.html
Are you facing this issue? #57
You can replace the gem with this:
And then run:
bundle update woocommerce_apiRemember to change it back when this PR is merged.