From 0ce11584510d36a2b4e8c0a46692141e37429670 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 7 Nov 2026 17:44:25 +0000 Subject: [PATCH 1/3] Initial plan From 548d4040510e3916d357ae1727664fab091dd5d0 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 7 Nov 2026 17:45:31 +0000 Subject: [PATCH 2/3] Rename AsyncHttpClient request method Co-authored-by: asika32764 <1639206+asika32764@users.noreply.github.com> --- packages/http/src/AsyncHttpClient.php | 2 +- packages/http/test/AsyncHttpClientTest.php | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/http/src/AsyncHttpClient.php b/packages/http/src/AsyncHttpClient.php index a6a54da51..42570de57 100644 --- a/packages/http/src/AsyncHttpClient.php +++ b/packages/http/src/AsyncHttpClient.php @@ -116,7 +116,7 @@ public function reset(): static * @return Promise * @throws RangeException */ - public function senRequest(RequestInterface $request): ResponseInterface + public function sendRequest(RequestInterface $request): ResponseInterface { /** @var CurlTransport $transport */ $transport = $this->getTransport(); diff --git a/packages/http/test/AsyncHttpClientTest.php b/packages/http/test/AsyncHttpClientTest.php index b8d57be52..7fb6cdd3b 100644 --- a/packages/http/test/AsyncHttpClientTest.php +++ b/packages/http/test/AsyncHttpClientTest.php @@ -93,9 +93,9 @@ public function setTransportRejectsStreamTransport(): void } #[Test] - public function senRequestQueuesTaskAndReturnsPromise(): void + public function sendRequestQueuesTaskAndReturnsPromise(): void { - $promise = $this->instance->senRequest($this->createRequest('/json?a=1')); + $promise = $this->instance->sendRequest($this->createRequest('/json?a=1')); self::assertInstanceOf(PromiseResponse::class, $promise); self::assertCount(1, $this->instance->getHandles()); @@ -105,8 +105,8 @@ public function senRequestQueuesTaskAndReturnsPromise(): void #[Test] public function resolveReturnsResponsesForAllQueuedRequests(): void { - $this->instance->senRequest($this->createRequest('/json?a=1')); - $this->instance->senRequest($this->createRequest('/json?a=2')); + $this->instance->sendRequest($this->createRequest('/json?a=1')); + $this->instance->sendRequest($this->createRequest('/json?a=2')); $responses = $this->instance->resolve(); @@ -122,7 +122,7 @@ public function resolveResolvesPromisesWithResponses(): void { $received = []; - $promise = $this->instance->senRequest($this->createRequest('/json?a=3')); + $promise = $this->instance->sendRequest($this->createRequest('/json?a=3')); $promise->then( function (Response $res) use (&$received) { $received[] = (string) $res->getBody(); @@ -139,7 +139,7 @@ function (Response $res) use (&$received) { #[Test] public function resolveInvokesCallbackWithResponsesErrorsAndClient(): void { - $this->instance->senRequest($this->createRequest('/json?a=1')); + $this->instance->sendRequest($this->createRequest('/json?a=1')); $args = null; @@ -159,7 +159,7 @@ public function resolveRejectsPromiseAndCollectsErrorOnConnectionFailure(): void { $failure = null; - $promise = $this->instance->senRequest( + $promise = $this->instance->sendRequest( $this->createUrlRequest('http://127.0.0.1:1/unreachable'), ); $promise->fail( @@ -187,7 +187,7 @@ function (array $responses, array $errs) use (&$errors) { #[Test] public function resolveResetsQueueAfterCompletion(): void { - $this->instance->senRequest($this->createRequest('/json?a=1')); + $this->instance->sendRequest($this->createRequest('/json?a=1')); $this->instance->resolve(); self::assertSame([], $this->instance->getHandles()); @@ -197,7 +197,7 @@ public function resolveResetsQueueAfterCompletion(): void #[Test] public function resetClearsTasksAndMainHandle(): void { - $this->instance->senRequest($this->createRequest('/json?a=1')); + $this->instance->sendRequest($this->createRequest('/json?a=1')); $mh = $this->instance->getMainHandle(); self::assertSame($this->instance, $this->instance->reset()); From 8763dad8bdb8020e1a0b098b9cd42be8e164793b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 7 Nov 2026 17:50:17 +0000 Subject: [PATCH 3/3] Keep deprecated AsyncHttpClient method alias Co-authored-by: asika32764 <1639206+asika32764@users.noreply.github.com> --- packages/http/src/AsyncHttpClient.php | 14 ++++++++++++++ packages/http/test/AsyncHttpClientTest.php | 10 ++++++++++ 2 files changed, 24 insertions(+) diff --git a/packages/http/src/AsyncHttpClient.php b/packages/http/src/AsyncHttpClient.php index 42570de57..90271f422 100644 --- a/packages/http/src/AsyncHttpClient.php +++ b/packages/http/src/AsyncHttpClient.php @@ -136,6 +136,20 @@ public function sendRequest(RequestInterface $request): ResponseInterface return $promise; } + /** + * Send a request to remote. + * + * @param RequestInterface $request The PSR request object. + * + * @return Promise + * + * @deprecated Use sendRequest() instead. + */ + public function senRequest(RequestInterface $request): ResponseInterface + { + return $this->sendRequest($request); + } + /** * resolve * diff --git a/packages/http/test/AsyncHttpClientTest.php b/packages/http/test/AsyncHttpClientTest.php index 7fb6cdd3b..5b9176888 100644 --- a/packages/http/test/AsyncHttpClientTest.php +++ b/packages/http/test/AsyncHttpClientTest.php @@ -102,6 +102,16 @@ public function sendRequestQueuesTaskAndReturnsPromise(): void self::assertCount(1, $this->instance->getTasks()); } + #[Test] + public function senRequestForwardsToSendRequest(): void + { + $promise = $this->instance->senRequest($this->createRequest('/json?a=1')); + + self::assertInstanceOf(PromiseResponse::class, $promise); + self::assertCount(1, $this->instance->getHandles()); + self::assertCount(1, $this->instance->getTasks()); + } + #[Test] public function resolveReturnsResponsesForAllQueuedRequests(): void {