feat(v4-to-v5): upgrade to new codemod

[AugustinMauroy]

Current state

Theses codemod as considered as legacy because they was using codemod v0

Also there aren't maintained anymore.

What we have todo

• migrate them to ast-grep instead of jscoshift
• publish them

[AugustinMauroy]

WAIT we just have to copy past them codemod team already migrate them to codemod for us.
https://github.com/codemod/webpack-codemods/tree/main/recipes/set-target-to-false-and-update-plugins

[avivkeller]

I'm not sure if it's right for us to re-export these codemods, they are not ours. (Discuss in this thread)

[AugustinMauroy]

@alexbit-codemod

[alexbit-codemod]

Here is a written consent and it's totally fine to use those codemods as is or with any modifications you want. And it's much appreciated too. Once you port them all here we can deprecate the other temp/unofficial repo.

[avivkeller]

Thanks for that @alexbit-codemod! Let me talk to the foundation's legal regarding license information (since the current license of the code contradicts ours, as in, they are licensed by different people). The best solution would be to include both copyright notices, I think, but I'd like to play it safe.

[bjohansebas]

P.S. I’m not going to block this, but is there value in making these official and maintaining them? I’ll review each one later, but I’d like these codemods to be related to the transition from webpack 5 to webpack 6.

[alexbit-codemod]

there are two sets of v4 to v5 codemods.

one set is the legacy codemods featured in the official upgrade guide.
https://webpack.js.org/migrate/5/#codemods
https://github.com/codemod/commons/tree/main/codemods/webpack/v5/migration-recipe

but there is also a second set of NEW webpack codemods that were never pressure-tested by the webpack team or featured for users:
https://github.com/codemod/webpack-codemods/tree/main/recipes/set-target-to-false-and-update-plugins
the latter were built by the Codemod team, and i have already given consent to use them, so no legal check is needed here.

as for the next step, i recommend @AugustinMauroy use these LOCALLY as a starting point:
https://github.com/codemod/webpack-codemods

fully test them, modify them as needed, and put the latest versions here.

once the new versions (with webpack scope) are published, on the Codemod end we can create aliases so that with ZERO changes to the current docs, running the old codemods will run the new ones under the hood. the new codemods offer plenty of benefits, as described here:
https://docs.codemod.com/jssg/intro#how-jssg-differs

but again, this is not mandatory. it's a nice cleanup to have and would also bring a little more credibility and visibility to webpack codemods. e.g. take a look at the registry search results when someone searches for webpack:
https://app.codemod.com/registry?q=webpack

compare it with node.js or eslint:
https://app.codemod.com/registry?q=scope:nodejs
https://app.codemod.com/registry?q=scope:eslint

so i leave it up to @AugustinMauroy if he really wants to do this clean up. (i encourage and appreciate that.)

[AugustinMauroy]

IMO we should have v4-to-v5 & v5-to-v6 in the same repo under the same Codemod registry scope (@webpack) so to accomplish that we should put them here.
Also other good point to have them here is in case of missing edge cases we can update them