From fb5a7664afab0acbbaf09ccbb9b2423cf6ff2f5f Mon Sep 17 00:00:00 2001 From: Mohd Sahil <110476034+MdSahil8130@users.noreply.github.com> Date: Fri, 18 Sep 2026 01:02:53 +0530 Subject: [PATCH] fix(ci): match unversioned DMG names in Homebrew tap workflow The Update Homebrew Tap workflow downloaded the macOS release assets with the patterns Recordly-*-arm64.dmg and Recordly-*-x64.dmg, which assume a version segment in the filename. electron-builder.json5 sets artifactName to "${productName}-${arch}.${ext}", so the published assets are Recordly-arm64.dmg and Recordly-x64.dmg. The wildcard requires a hyphen on both sides, so the patterns never matched and "gh release download" exited with "no assets match the file pattern", failing the job at the download step on every run. Use the exact names the release publishes, matching the convention already used in scripts/verify-macos-distribution.mjs. --- .github/workflows/homebrew-tap.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/homebrew-tap.yml b/.github/workflows/homebrew-tap.yml index 5f8549ec9..307ab1194 100644 --- a/.github/workflows/homebrew-tap.yml +++ b/.github/workflows/homebrew-tap.yml @@ -54,16 +54,16 @@ jobs: gh release download "${{ steps.tag.outputs.tag }}" \ --repo "${{ github.repository }}" \ --dir /tmp/recordly-release \ - --pattern "Recordly-*-arm64.dmg" \ - --pattern "Recordly-*-x64.dmg" + --pattern "Recordly-arm64.dmg" \ + --pattern "Recordly-x64.dmg" - name: Compute checksums id: sha shell: bash run: | set -euo pipefail - ARM_FILE=$(find /tmp/recordly-release -maxdepth 1 -name 'Recordly-*-arm64.dmg' | head -n 1) - INTEL_FILE=$(find /tmp/recordly-release -maxdepth 1 -name 'Recordly-*-x64.dmg' | head -n 1) + ARM_FILE=$(find /tmp/recordly-release -maxdepth 1 -name 'Recordly-arm64.dmg' | head -n 1) + INTEL_FILE=$(find /tmp/recordly-release -maxdepth 1 -name 'Recordly-x64.dmg' | head -n 1) if [ -z "$ARM_FILE" ] || [ -z "$INTEL_FILE" ]; then echo "Unable to locate macOS release artifacts for ${{ steps.tag.outputs.tag }}"