Skip to content

Update CICs to match actual code behavior (Cluster F) #17

@Polichinel

Description

@Polichinel

Context

The falsification campaign (Claims 1.1, 1.2) found that both CICs describe aspirational behavior, not actual behavior. 5 specific discrepancies:

PriogridCountryMapper CIC

  1. §3 cache guarantee: Says "cache mode does not affect results." Reality: C-05 documents 6 methods that crash in disk mode. Needs caveat.
  2. §5 return types: Says find_country_for_gid returns 4 keys. Reality: returns ~170 keys (all Natural Earth columns dumped). Needs full documentation or code fix.
  3. §6 log level: Says intersection failures logged as "WARNING." Reality: 7 sites use logger.debug. Needs to say DEBUG.
  4. §5 admin1 return: Lists 4 keys. Reality: also returns gaul0_code, gaul0_name, continent, disp_en. Needs complete listing.

UNFAOPostProcessorManager CIC

  1. §3 ADR-008 compliance: Claims "all structural failures are logged and raised." Reality: 3 of 7 raises in unfao.py lack preceding logger.error (C-19).
  2. §6 env var boundary: Claims missing env vars "must cause failure." Reality: os.getenv() returns None and passes it to AppwriteConfig without validation.

Requirements

Update both CICs to describe what the code DOES, not what we wish it did. Specifically:

  • Add C-05 caveat to cache guarantee
  • Document actual return key sets (or note "additional shapefile columns included")
  • Change "WARNING" to "DEBUG" in §6
  • Qualify ADR-008 claim as "partially compliant" with cross-ref to C-19
  • Qualify env var boundary claim with cross-ref to the validation gap

Risk Register

Cluster F (documentation accuracy risk, not code risk).
Campaign: Claims 1.1 (FALSIFIED 3H/1S), 1.2 (FALSIFIED 2H).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions