From 520c8f16733722810976c31980da3f63f2a4ef10 Mon Sep 17 00:00:00 2001 From: bjornkellner Date: Fri, 6 Nov 2026 09:57:25 +0100 Subject: [PATCH 1/2] Hash is is not platform dependant. Always 8byte little endian --- lib/twingly/url/hasher.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/twingly/url/hasher.rb b/lib/twingly/url/hasher.rb index 23e7ae6..7ce0840 100644 --- a/lib/twingly/url/hasher.rb +++ b/lib/twingly/url/hasher.rb @@ -20,11 +20,11 @@ def taskdb_hash(url) end def documentdb_hash(url) - SHA256_DIGEST.digest(url).unpack("L!")[0] + SHA256_DIGEST.digest(url).unpack("Q<")[0] end def autopingdb_hash(url) - SHA256_DIGEST.digest(url).unpack("q")[0] + SHA256_DIGEST.digest(url).unpack("q<")[0] end end end From 67897b15b5d6d2a138da91dd2ae28932cc1918f5 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 11 Nov 2026 07:17:27 +0000 Subject: [PATCH 2/2] Clarify fixed hash byte order Co-authored-by: bjornkellner <7229061+bjornkellner@users.noreply.github.com> --- README.md | 4 ++-- spec/lib/twingly/url/hasher_spec.rb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 5c5f5e6..a26e573 100644 --- a/README.md +++ b/README.md @@ -8,8 +8,8 @@ Twingly URL tools. * `Twingly::URL.parse` - Returns one or more `Twingly::URL` instance * `twingly/url/hasher` - Generate URL hashes suitable for primary keys * `Twingly::URL::Hasher.taskdb_hash(url)` - MD5 hexdigest - * `Twingly::URL::Hasher.documentdb_hash(url)` - SHA256 unsigned long, native endian digest - * `Twingly::URL::Hasher.autopingdb_hash(url)` - SHA256 64-bit signed, native endian digest + * `Twingly::URL::Hasher.documentdb_hash(url)` - SHA256 unsigned 64-bit little-endian digest + * `Twingly::URL::Hasher.autopingdb_hash(url)` - SHA256 64-bit signed little-endian digest * `twingly/url/utilities` - Utilities to work with URLs * `Twingly::URL::Utilities.extract_valid_urls` - Returns Array of valid `Twingly::URL` * `twingly/url/extended` - Extended normalization and hashing, stripping blacklisted query and matrix parameters as well as the fragment. diff --git a/spec/lib/twingly/url/hasher_spec.rb b/spec/lib/twingly/url/hasher_spec.rb index 464aa0b..34257b0 100644 --- a/spec/lib/twingly/url/hasher_spec.rb +++ b/spec/lib/twingly/url/hasher_spec.rb @@ -12,7 +12,7 @@ end describe ".documentdb_hash" do - it "returns a SHA256 unsigned long, native endian digest" do + it "returns a SHA256 unsigned 64-bit little-endian digest" do expect(Twingly::URL::Hasher.documentdb_hash("http://blog.twingly.com/")).to eq 15340752212397415993 end end @@ -20,7 +20,7 @@ describe ".autopingdb_hash" do let(:expected) { -3105991861312135623 } - it "returns a SHA256 64-bit signed, native endian digest" do + it "returns a SHA256 64-bit signed little-endian digest" do expect(Twingly::URL::Hasher.autopingdb_hash("http://blog.twingly.com/")).to eq expected end end