Skip to content

Commit bcc55d6

Browse files
committed
chore(webapp): tidy Slack support-channel release note and admin unlink
Collapse the release note back to a single entry, add a confirmation to the admin unlink action, and clarify the best-effort team-domain lookup.
1 parent 4abbd10 commit bcc55d6

5 files changed

Lines changed: 15 additions & 14 deletions

File tree

.server-changes/slack-support-channel-admin-downgrade.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

.server-changes/slack-support-channel-unlink.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.support.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ export default function Page() {
137137
</div>
138138
) : supportChannel?.status === "PROVISIONING" ? (
139139
<Paragraph variant="small" className="text-text-dimmed">
140-
Setting up your channel — check your email shortly for the Slack Connect invite.
140+
Setting up your channel. Check your email shortly for the Slack Connect invite.
141141
</Paragraph>
142142
) : (
143143
<Form method="post" className="flex flex-col gap-3">

apps/webapp/app/routes/admin.slack-channels.tsx

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,18 @@ function ChannelRow({
357357
</TableCell>
358358
<TableCell>
359359
{linkedInfo && (
360-
<unlinkFetcher.Form method="post">
360+
<unlinkFetcher.Form
361+
method="post"
362+
onSubmit={(e) => {
363+
if (
364+
!window.confirm(
365+
"Archive this Slack support channel and unlink it from the organization? The customer will lose access."
366+
)
367+
) {
368+
e.preventDefault();
369+
}
370+
}}
371+
>
361372
<input type="hidden" name="organizationId" value={linkedInfo.organizationId} />
362373
<Button
363374
type="submit"

apps/webapp/app/services/supportSlackChannel.server.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,8 @@ export class SupportSlackClientLive implements SupportSlackClient, SupportSlackD
148148
const res = await this.client.team.info({ team: teamId });
149149
return { domain: res.team?.domain, emailDomain: res.team?.email_domain };
150150
} catch {
151+
// Best-effort enrichment only: cross-org team.info can fail, and the domain is
152+
// just a matching hint. Fall back to no domains rather than failing discovery.
151153
return {};
152154
}
153155
}

0 commit comments

Comments
 (0)