From dcf30d8b446cda539d085ccf98cf3c0827ae5366 Mon Sep 17 00:00:00 2001
From: tijmen <tijmenbruggeman@gmail.com>
Date: Mon, 27 Jul 2026 10:14:24 +0200
Subject: [PATCH 1/3] fix php 8 test

---
 test/unit/TinyImageSizeTest.php | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/test/unit/TinyImageSizeTest.php b/test/unit/TinyImageSizeTest.php
index c77213ad..5db46931 100644
--- a/test/unit/TinyImageSizeTest.php
+++ b/test/unit/TinyImageSizeTest.php
@@ -194,8 +194,12 @@ public function test_resized_should_return_false_if_meta_have_output_and_not_res
 	}
 
 	public function test_will_read_mimetype_from_file() {
-		// because files in the virtual file system are not really files but empty strings, it is a text/plain.
-		$this->assertEquals( $this->original->mimetype(), 'text/plain');
+		// vfs files are empty buffers
+		// empty buffers on php < 8 returns 'text/plain', > 8 is 'application/octet-stream'
+		$this->assertContains(
+			$this->original->mimetype(),
+			array( 'text/plain', 'application/octet-stream' )
+		);
 	}
 
 	/**

From 6527740b7507cee5426d18fb22be476ef793630c Mon Sep 17 00:00:00 2001
From: tijmen <tijmenbruggeman@gmail.com>
Date: Mon, 17 Aug 2026 13:39:48 +0200
Subject: [PATCH 2/3] `drawSomeRows()` records the last index it drew instead
 of how many rows it has drawn

---
 src/js/bulk-optimization.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/js/bulk-optimization.js b/src/js/bulk-optimization.js
index 8fa55b49..207e4358 100644
--- a/src/js/bulk-optimization.js
+++ b/src/js/bulk-optimization.js
@@ -213,7 +213,7 @@
         <td class="column-author status" data-testid="bulk-item-status-${i}" data-colname="${tinyCompress.L10nStatus}" data-status="waiting">${tinyCompress.L10nWaiting}</td>
       </tr>`;
       list.append(tableRow);
-      drawNow = i;
+      drawNow = i + 1;
     }
     window.totalRowsDrawn = drawNow;
   }

From cfb40d647769cdb2f913fa848339f6467e532297 Mon Sep 17 00:00:00 2001
From: tijmen <tijmenbruggeman@gmail.com>
Date: Mon, 17 Aug 2026 13:54:36 +0200
Subject: [PATCH 3/3] can use immediate end variable

---
 src/js/bulk-optimization.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/js/bulk-optimization.js b/src/js/bulk-optimization.js
index 207e4358..4f4fd6a1 100644
--- a/src/js/bulk-optimization.js
+++ b/src/js/bulk-optimization.js
@@ -202,8 +202,9 @@
 
   function drawSomeRows(items, rowsToDraw) {
     const list = jQuery('#optimization-items tbody');
-    let drawNow = window.totalRowsDrawn;
-    for(let i = drawNow;i < Math.min(rowsToDraw + window.totalRowsDrawn, items.length); i++) {
+    const start = window.totalRowsDrawn;
+    const end = Math.min(start + rowsToDraw, items.length);
+    for (let i = start; i < end; i++) {
       const tableRow = `<tr class="media-item">
         <td class="thumbnail" />
         <td class="column-primary name">${items[i].post_title}</th>
@@ -213,9 +214,8 @@
         <td class="column-author status" data-testid="bulk-item-status-${i}" data-colname="${tinyCompress.L10nStatus}" data-status="waiting">${tinyCompress.L10nWaiting}</td>
       </tr>`;
       list.append(tableRow);
-      drawNow = i + 1;
     }
-    window.totalRowsDrawn = drawNow;
+    window.totalRowsDrawn = end;
   }
 
   function cancelOptimization() {