pyxray.draw is the character art module. It landed in #34 with 18 tests, and at the time it was the only way a lesson could show a shape.
#42 changed that. Structural pictures are Excalidraw scenes now, and T02 dropped every one of its fenced art blocks in favour of them. So draw needs a decision rather than drifting along being half used.
There are three honest options.
Delete it, and move the callers to nbdiagram. Cleanest, and wrong if any of them are producing something from data at run time, because a scene cannot do that.
Keep it for run time output only. tokens.ribbon and tokens.staircase both draw from a source string the reader supplied, and both print into an output cell where an SVG cannot go. That is a real job with no replacement, and if this is the answer then the module's docstring should say so, because right now it reads as the general drawing tool and it is not that any more.
Keep it as the fallback for a reader with no network. A Colab notebook whose images are all absolute URLs into this repository shows nothing useful offline. That is a weak argument on its own but it is not nothing.
The second option looks right from here. What it needs is somebody to check which callers are actually run time and which were only using it because there was no alternative, then write the answer into the module docstring so the next person does not have to work it out again.
pyxray.drawis the character art module. It landed in #34 with 18 tests, and at the time it was the only way a lesson could show a shape.#42 changed that. Structural pictures are Excalidraw scenes now, and T02 dropped every one of its fenced art blocks in favour of them. So
drawneeds a decision rather than drifting along being half used.There are three honest options.
Delete it, and move the callers to
nbdiagram. Cleanest, and wrong if any of them are producing something from data at run time, because a scene cannot do that.Keep it for run time output only.
tokens.ribbonandtokens.staircaseboth draw from a source string the reader supplied, and both print into an output cell where an SVG cannot go. That is a real job with no replacement, and if this is the answer then the module's docstring should say so, because right now it reads as the general drawing tool and it is not that any more.Keep it as the fallback for a reader with no network. A Colab notebook whose images are all absolute URLs into this repository shows nothing useful offline. That is a weak argument on its own but it is not nothing.
The second option looks right from here. What it needs is somebody to check which callers are actually run time and which were only using it because there was no alternative, then write the answer into the module docstring so the next person does not have to work it out again.