From d1a74d8997c930006435a51e674715491df752d9 Mon Sep 17 00:00:00 2001 From: Ovi Trif Date: Tue, 8 Sep 2026 23:31:34 +0200 Subject: [PATCH 1/4] chore: enforce figma links in relevant prs --- .agents/commands/pr.md | 8 ++++++++ .github/pull_request_template.md | 10 ++++++++++ AGENTS.md | 11 +++++++++++ 3 files changed, 29 insertions(+) diff --git a/.agents/commands/pr.md b/.agents/commands/pr.md index ccdde89d3..dab725387 100644 --- a/.agents/commands/pr.md +++ b/.agents/commands/pr.md @@ -111,6 +111,14 @@ When the user provides custom instructions after `--`: - Preserve exact manual testing steps provided by the user (don't summarize or omit details) - If custom instructions include automated checks or coverage notes, place them under `#### Automated Checks` +**Design:** +- Always include a `### Design` section. +- For user-visible UI changes with an existing design, link the relevant Figma frames, using the screens map as the starting point. +- For user-visible UI changes with no available design, including new features, write `N/A — no design available.` +- For changes without user-visible UI changes, write `N/A — no UI changes.` +- If a screens-map entry is missing or uncertain, state the uncertainty. +- Never invent a Figma link or require a new design. + **QA Notes / Validation:** - QA Notes separate actionable human QA instructions from automated verification coverage. - Always use this structure: diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ac5c0fee6..07c536f68 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,6 +8,16 @@ Please include a summary of changes and which issues are fixed. Please also incl Add any links to GitHub issues or Asana tasks that are relevant to this pull request. +### Design + + + ### Screenshot / Video Insert relevant screenshot / recording diff --git a/AGENTS.md b/AGENTS.md index 0e77a0169..800e66822 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -337,6 +337,17 @@ New feature (`TransferTrackingManager`) tracks pending transfers to handle edge Ensure accessibility modifiers and labels are added to custom components. +### Figma Designs + +- UI PRs with an existing design must link the relevant Figma frames under `### Design`, using the screens map as the starting point. +- UI PRs with no available design, including new features, must use `N/A — no design available.` under `### Design`. +- PRs without user-visible UI changes must use `N/A — no UI changes.` under `### Design`. +- Missing or uncertain screens-map entries must be reported honestly. +- Never invent a Figma link or require a new design. +- Reviewers may make at most one advisory request when an existing-design UI PR omits its Figma link. +- Explicit `N/A` cases need no review request. +- Missing Figma links never block approval or CI. + ## Code Style & Conventions - **SwiftFormat** configuration in `.swiftformat` From 25ed5c32fb61bd00ecc0ea2ad2e7e044a13a594b Mon Sep 17 00:00:00 2001 From: Ovi Trif Date: Wed, 9 Sep 2026 13:27:45 +0200 Subject: [PATCH 2/4] docs: address figma policy reviews --- .agents/commands/pr.md | 7 +++++-- .agents/commands/release.md | 4 ++++ .github/pull_request_template.md | 4 ++-- AGENTS.md | 4 ++-- 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/.agents/commands/pr.md b/.agents/commands/pr.md index dab725387..0e7161f09 100644 --- a/.agents/commands/pr.md +++ b/.agents/commands/pr.md @@ -113,11 +113,14 @@ When the user provides custom instructions after `--`: **Design:** - Always include a `### Design` section. -- For user-visible UI changes with an existing design, link the relevant Figma frames, using the screens map as the starting point. +- For user-visible UI changes with an existing design, link the relevant Figma frames, starting with the latest `Bitkit - Handoff vNN` page. - For user-visible UI changes with no available design, including new features, write `N/A — no design available.` - For changes without user-visible UI changes, write `N/A — no UI changes.` -- If a screens-map entry is missing or uncertain, state the uncertainty. +- If the relevant Figma frame is missing or uncertain, state the uncertainty. - Never invent a Figma link or require a new design. +- Reviewers may make at most one advisory request when an existing-design UI PR omits its Figma link. +- Explicit `N/A` cases need no review request. +- Missing Figma links never block approval or CI. **QA Notes / Validation:** - QA Notes separate actionable human QA instructions from automated verification coverage. diff --git a/.agents/commands/release.md b/.agents/commands/release.md index 3d7c9b2b7..f154965e7 100644 --- a/.agents/commands/release.md +++ b/.agents/commands/release.md @@ -126,6 +126,10 @@ Bump version to {newVersionName} (build {newBuildNumber}) for release. - `CURRENT_PROJECT_VERSION`: {oldBuildNumber} → {newBuildNumber} - `MARKETING_VERSION`: {oldVersionName} → {newVersionName} +### Design + +N/A — no UI changes. + ### Screenshot / Video N/A diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 07c536f68..4d903d5aa 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,10 +11,10 @@ Add any links to GitHub issues or Asana tasks that are relevant to this pull req ### Design diff --git a/AGENTS.md b/AGENTS.md index 800e66822..dcb5c3fa9 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -339,10 +339,10 @@ Ensure accessibility modifiers and labels are added to custom components. ### Figma Designs -- UI PRs with an existing design must link the relevant Figma frames under `### Design`, using the screens map as the starting point. +- UI PRs with an existing design must link the relevant Figma frames under `### Design`, starting with the latest `Bitkit - Handoff vNN` page. - UI PRs with no available design, including new features, must use `N/A — no design available.` under `### Design`. - PRs without user-visible UI changes must use `N/A — no UI changes.` under `### Design`. -- Missing or uncertain screens-map entries must be reported honestly. +- Missing or uncertain Figma frames must be reported honestly. - Never invent a Figma link or require a new design. - Reviewers may make at most one advisory request when an existing-design UI PR omits its Figma link. - Explicit `N/A` cases need no review request. From 936b439e29cd6c4f97e5d86120952f6e8ed913bb Mon Sep 17 00:00:00 2001 From: Ovi Trif Date: Wed, 9 Sep 2026 17:32:10 +0200 Subject: [PATCH 3/4] docs: clarify figma n/a reviews --- .agents/commands/pr.md | 2 +- AGENTS.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.agents/commands/pr.md b/.agents/commands/pr.md index 0e7161f09..b94098152 100644 --- a/.agents/commands/pr.md +++ b/.agents/commands/pr.md @@ -119,7 +119,7 @@ When the user provides custom instructions after `--`: - If the relevant Figma frame is missing or uncertain, state the uncertainty. - Never invent a Figma link or require a new design. - Reviewers may make at most one advisory request when an existing-design UI PR omits its Figma link. -- Explicit `N/A` cases need no review request. +- `N/A — no UI changes.` needs no review request; `N/A — no design available.` may receive the single advisory clarification. - Missing Figma links never block approval or CI. **QA Notes / Validation:** diff --git a/AGENTS.md b/AGENTS.md index dcb5c3fa9..26b9398e0 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -345,7 +345,7 @@ Ensure accessibility modifiers and labels are added to custom components. - Missing or uncertain Figma frames must be reported honestly. - Never invent a Figma link or require a new design. - Reviewers may make at most one advisory request when an existing-design UI PR omits its Figma link. -- Explicit `N/A` cases need no review request. +- `N/A — no UI changes.` needs no review request; `N/A — no design available.` may receive the single advisory clarification. - Missing Figma links never block approval or CI. ## Code Style & Conventions From aa48564e8486210a2eb15546ed04483b1da20de0 Mon Sep 17 00:00:00 2001 From: Ovi Trif Date: Thu, 10 Sep 2026 11:59:23 +0200 Subject: [PATCH 4/4] docs: address figma policy feedback --- .agents/commands/pr.md | 8 ++++---- .github/pull_request_template.md | 2 +- AGENTS.md | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.agents/commands/pr.md b/.agents/commands/pr.md index b94098152..05f1cc9bf 100644 --- a/.agents/commands/pr.md +++ b/.agents/commands/pr.md @@ -112,15 +112,15 @@ When the user provides custom instructions after `--`: - If custom instructions include automated checks or coverage notes, place them under `#### Automated Checks` **Design:** -- Always include a `### Design` section. -- For user-visible UI changes with an existing design, link the relevant Figma frames, starting with the latest `Bitkit - Handoff vNN` page. +- Include a `### Design` section when the PR template contains a `### Design` heading. +- For user-visible UI changes with an existing design, link the relevant Figma frames, starting with the latest `Bitkit - Handoff vNN` page in https://www.figma.com/design/ltqvnKiejWj0JQiqtDf2JJ/. - For user-visible UI changes with no available design, including new features, write `N/A — no design available.` - For changes without user-visible UI changes, write `N/A — no UI changes.` - If the relevant Figma frame is missing or uncertain, state the uncertainty. - Never invent a Figma link or require a new design. -- Reviewers may make at most one advisory request when an existing-design UI PR omits its Figma link. +- Reviewers may make at most one advisory request per PR when an existing-design UI PR omits its Figma link. - `N/A — no UI changes.` needs no review request; `N/A — no design available.` may receive the single advisory clarification. -- Missing Figma links never block approval or CI. +- Missing Figma links never block approval, CI, PR creation, or review readiness. **QA Notes / Validation:** - QA Notes separate actionable human QA instructions from automated verification coverage. diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4d903d5aa..526002e03 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,7 +11,7 @@ Add any links to GitHub issues or Asana tasks that are relevant to this pull req ### Design