Skip to content

Commit 9e1173b

Browse files
committed
PHP-66 - Update line endings to be actual LF
1 parent 0f4fcf8 commit 9e1173b

5 files changed

Lines changed: 34 additions & 8 deletions

File tree

src/Stackify/Log/Filters/LogMsg/ErrorStackTraceMaskFilter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public function filter(LogMsg $logMsg)
2323
return $logMsg;
2424
}
2525

26-
if (stripos($logMsg->getMessage(), 'stack trace:\\n') === false) {
26+
if (stripos($logMsg->getMessage(), "stack trace:\n") === false) {
2727
return $logMsg;
2828
}
2929

@@ -48,7 +48,7 @@ protected function mask($message)
4848
}
4949

5050
try {
51-
$delimeter = '\\n';
51+
$delimeter = "\n";
5252
$hasObject = strpos($message, 'Object(') !== false; // Checks if we can detect an object(
5353
$messageParts = explode($delimeter, $message);
5454

tests/Log/Builder/Fixtures/ExampleLogMsgFilterWithStackTrace.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class ExampleLogMsgFilterWithStackTrace implements LogMsgFilterable
1010
public function filter(LogMsg $logMsg)
1111
{
1212
$logMsg->setMessage(
13-
'Stack trace:\\n : SomeExampleFunction'.$logMsg->getMessage().'(\''.$logMsg->getMessage().'\')'
13+
"Stack trace:\n : SomeExampleFunction".$logMsg->getMessage()."(\'".$logMsg->getMessage()."\')"
1414
);
1515
return $logMsg;
1616
}

tests/Log/Builder/MessageBuilderTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public function testMaskErrorStackTraceArgumentsCreateLogMsg()
9595
$this->assertSame(count($messageBuilder->getLogMessageFilters()), 1);
9696
$logEntry = $this->createLogEntry(
9797
'error',
98-
'Stack trace:\\n : SomeFunction(\'test\')',
98+
"Stack trace:\n : SomeFunction(\'test\')",
9999
array(
100100
'error' => new \Exception('test')
101101
)
@@ -105,7 +105,7 @@ public function testMaskErrorStackTraceArgumentsCreateLogMsg()
105105
$logEntry
106106
);
107107

108-
$this->assertSame($logMsg->getMessage(), 'Stack trace:\n : SomeFunction()');
108+
$this->assertSame($logMsg->getMessage(), "Stack trace:\n : SomeFunction()");
109109
}
110110

111111
public function testMaskErrorStackTraceArgumentsWithFiltersCreateLogMsg()
@@ -141,7 +141,7 @@ public function testMaskErrorStackTraceArgumentsWithFiltersCreateLogMsg()
141141

142142
$this->assertSame(
143143
$logMsg->getMessage(),
144-
'Stack trace:\\n : SomeExampleFunctionTest1()' // Test1 just to confirm we filter the first message on the pipeline
144+
"Stack trace:\n : SomeExampleFunctionTest1()" // Test1 just to confirm we filter the first message on the pipeline
145145
);
146146
}
147147

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,14 @@
1-
yii\\base\\ErrorException: mysqli_connect(): (HY000\/2002): No such file or directory in \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php:144\nStack trace:\n#0 [internal function]: yii\\base\\ErrorHandler->handleError(2, 'mysqli_connect(...', '\/mnt\/d\/Projects...', 144, Array)\n#1 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php(144): mysqli_connect('localhost', 'root', 'password')\n#2 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php(138): app\\controllers\\SiteController->testWithArguments('testtest')\n#3 [internal function]: app\\controllers\\SiteController->actionTest()\n#4 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/InlineAction.php(57): call_user_func_array(Array, Array)\n#5 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Controller.php(181): yii\\base\\InlineAction->runWithParams(Array)\n#6 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Module.php(534): yii\\base\\Controller->runAction('test', Array)\n#7 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/web\/Application.php(104): yii\\base\\Module->runAction('site\/test', Array)\n#8 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Application.php(392): yii\\web\\Application->handleRequest(Object(yii\\web\\Request))\n#9 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Application.php(392): yii\\web\\Application->handleRequest(Object(yii\\web\\Request),'test',123,Object(yii\\web\\Request))\n#10 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/web\/index.php(12): yii\\base\\Application->run()\n#11 {main}
1+
yii\\base\\ErrorException: mysqli_connect(): (HY000\/2002): No such file or directory in \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php:144
2+
Stack trace:
3+
#0 [internal function]: yii\\base\\ErrorHandler->handleError(2, 'mysqli_connect(...', '\/mnt\/d\/Projects...', 144, Array)
4+
#1 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php(144): mysqli_connect('localhost', 'root', 'password')
5+
#2 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php(138): app\\controllers\\SiteController->testWithArguments('testtest')
6+
#3 [internal function]: app\\controllers\\SiteController->actionTest()
7+
#4 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/InlineAction.php(57): call_user_func_array(Array, Array)
8+
#5 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Controller.php(181): yii\\base\\InlineAction->runWithParams(Array)
9+
#6 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Module.php(534): yii\\base\\Controller->runAction('test', Array)
10+
#7 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/web\/Application.php(104): yii\\base\\Module->runAction('site\/test', Array)
11+
#8 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Application.php(392): yii\\web\\Application->handleRequest(Object(yii\\web\\Request))
12+
#9 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Application.php(392): yii\\web\\Application->handleRequest(Object(yii\\web\\Request),'test',123,Object(yii\\web\\Request))
13+
#10 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/web\/index.php(12): yii\\base\\Application->run()
14+
#11 {main}
Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,14 @@
1-
yii\\base\\ErrorException: mysqli_connect(): (HY000\/2002): No such file or directory in \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php:144\nStack trace:\n#0 [internal function]: yii\\base\\ErrorHandler->handleError()\n#1 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php(144): mysqli_connect()\n#2 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php(138): app\\controllers\\SiteController->testWithArguments()\n#3 [internal function]: app\\controllers\\SiteController->actionTest()\n#4 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/InlineAction.php(57): call_user_func_array()\n#5 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Controller.php(181): yii\\base\\InlineAction->runWithParams()\n#6 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Module.php(534): yii\\base\\Controller->runAction()\n#7 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/web\/Application.php(104): yii\\base\\Module->runAction()\n#8 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Application.php(392): yii\\web\\Application->handleRequest()\n#9 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Application.php(392): yii\\web\\Application->handleRequest()\n#10 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/web\/index.php(12): yii\\base\\Application->run()\n#11 {main}
1+
yii\\base\\ErrorException: mysqli_connect(): (HY000\/2002): No such file or directory in \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php:144
2+
Stack trace:
3+
#0 [internal function]: yii\\base\\ErrorHandler->handleError()
4+
#1 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php(144): mysqli_connect()
5+
#2 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/controllers\/SiteController.php(138): app\\controllers\\SiteController->testWithArguments()
6+
#3 [internal function]: app\\controllers\\SiteController->actionTest()
7+
#4 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/InlineAction.php(57): call_user_func_array()
8+
#5 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Controller.php(181): yii\\base\\InlineAction->runWithParams()
9+
#6 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Module.php(534): yii\\base\\Controller->runAction()
10+
#7 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/web\/Application.php(104): yii\\base\\Module->runAction()
11+
#8 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Application.php(392): yii\\web\\Application->handleRequest()
12+
#9 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/vendor\/yiisoft\/yii2\/base\/Application.php(392): yii\\web\\Application->handleRequest()
13+
#10 \/mnt\/d\/Projects\/projects-php\/samples\/yii-basic-2.0.38\/web\/index.php(12): yii\\base\\Application->run()
14+
#11 {main}

0 commit comments

Comments
 (0)