Merge pull request #17 from homiedopie/feature/INV-1576-1567

Fix log function and get trace checking

Author: homiedopie

src/Stackify/Log/Builder/MessageBuilder.php

@@ -94,13 +94,18 @@ protected function getErrorItem(ErrorWrapper $errorWrapper)
         $errorItem->ErrorType = $errorWrapper->getType();
         $errorItem->ErrorTypeCode = $errorWrapper->getCode();
         $errorItem->SourceMethod = $errorWrapper->getSourceMethod();
-        foreach ($errorWrapper->getTrace() as $index => $trace) {
-            $errorItem->StackTrace[] = new TraceFrame(
-                $trace['file'],
-                $trace['line'],
-                $trace['function']
-            );
+
+        $errorWrapperTrace = $errorWrapper->getTrace();
+        if ($errorWrapperTrace && is_array($errorWrapperTrace)) {
+            foreach ($errorWrapper->getTrace() as $index => $trace) {
+                $errorItem->StackTrace[] = new TraceFrame(
+                    $trace['file'],
+                    $trace['line'],
+                    $trace['function']
+                );
+            }
         }
+
         $previous = $errorWrapper->getInnerError();
         if ($previous) {
             $errorItem->InnerError = $this->getErrorItem($previous);

src/Stackify/Log/Transport/Config/AbstractConfig.php

@@ -391,7 +391,7 @@ public function setCaptureErrorCookiesBlacklist($rawConfig = null)
     public function setDebugLogPath($path)
     {
         if ($path == null) {
-            $this->log('[DebugLogPath] is not valid.');
+            $this->logError('[DebugLogPath] is not valid.');
             return;
         }
 
@@ -636,8 +636,12 @@ protected function logDebug($message)
      *
      * @return void
      */
-    protected function log($message, $args, $success = true)
+    protected function log($message, $args = null, $success = true)
     {
+        if ($args == null) {
+            $args = array();
+        }
+
         $replacements = array_slice($args, 1);
         $prefix = $success ? 'Stackify Log' : 'Stackify Error';
         $template = "[$prefix][Config] $message";
@@ -661,7 +665,7 @@ protected function log($message, $args, $success = true)
     public function extract($config = null)
     {
         if (is_array($config) == false) {
-            $this->log('['. __CLASS__ .']['. __FUNCTION__ .'] $config is not an array.');
+            $this->logDebug('['. __CLASS__ .']['. __FUNCTION__ .'] $config is not an array.');
             return;
         }
 
@@ -674,7 +678,7 @@ public function extract($config = null)
                     continue;
                 }
 
-                $this->log('['. __CLASS__ .']['. __FUNCTION__ .']' . $method .' does not exists.');
+                $this->logDebug('['. __CLASS__ .']['. __FUNCTION__ .']' . $method .' does not exists.');
             }
         }
     }
@@ -716,7 +720,7 @@ protected function parseStringToArray($string = null, $property = null)
     protected function getBoolean($enable = null,  $property = null)
     {
         if (is_bool($enable) == false) {
-            $this->log('['.$property.'] is not a boolean.');
+            $this->logError('['.$property.'] is not a boolean.');
             return null;
         }
 

src/Stackify/Log/Transport/Config/Agent.php

@@ -408,7 +408,7 @@ public function getApiVersionHeader()
      *
      * @return void
      */
-    protected function log($message, $args, $success = true)
+    protected function log($message, $args = null, $success = true)
     {
         return parent::log('['.get_class().']'.$message, $args, $success);
     }