codegen/golang: name the engines with constants; ci: build the end-to-end module with cgo

The end-to-end module is one of its own, so cgo there is no concern of
sqlc's builds, and the DuckDB golden compiles with the rest again.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015rfiHyC4iRLyRWc3UmYEtT

Author: claude

.github/workflows/ci.yml

@@ -47,13 +47,11 @@ jobs:
       env:
         CGO_ENABLED: "0"
 
-    # The DuckDB golden imports the DuckDB driver, which is cgo, so it is
-    # left out of this build and checked by the replay suite alone.
+    # A module of its own, so cgo stays on for the DuckDB driver the
+    # DuckDB golden imports.
     - name: build internal/endtoend
-      run: go build $(go list ./... | grep -v '/core_types/duckdb/')
+      run: go build ./...
       working-directory: internal/endtoend/testdata
-      env:
-        CGO_ENABLED: "0"
 
     - name: install databases
       run: go run ./cmd/sqlc-test-setup install postgresql mysql

Makefile

@@ -21,7 +21,7 @@ test-examples:
 	cd ./examples && go test --tags=examples ./...
 
 build-endtoend:
-	cd ./internal/endtoend/testdata && CGO_ENABLED=0 go build $$(go list ./... | grep -v '/core_types/duckdb/')
+	cd ./internal/endtoend/testdata && go build ./...
 
 test-ci: test-examples build-endtoend vet
 

internal/codegen/golang/driver.go

@@ -13,13 +13,24 @@ func parseDriver(sqlPackage string) opts.SQLDriver {
 	}
 }
 
+// The engines, as the request names them.
+const (
+	engineClickHouse = "clickhouse"
+	engineDuckDB     = "duckdb"
+	engineGoogleSQL  = "googlesql"
+	engineMSSQL      = "mssql"
+	engineMySQL      = "mysql"
+	enginePostgreSQL = "postgresql"
+	engineSQLite     = "sqlite"
+)
+
 // usesPqArrays reports whether the queries pass array values through
 // pq.Array. That is how lib/pq reads and writes PostgreSQL arrays, so it
 // holds for PostgreSQL under database/sql; pgx and the other engines'
 // drivers scan a slice directly.
 func usesPqArrays(engine string, driver opts.SQLDriver) bool {
 	switch engine {
-	case "clickhouse", "duckdb", "googlesql", "mssql":
+	case engineClickHouse, engineDuckDB, engineGoogleSQL, engineMSSQL:
 		return false
 	}
 	return !driver.IsPGX()

internal/codegen/golang/go_type.go

@@ -97,19 +97,19 @@ func goInnerType(req *plugin.GenerateRequest, options *opts.Options, col *plugin
 
 	// TODO: Extend the engine interface to handle types
 	switch req.Settings.Engine {
-	case "mysql":
+	case engineMySQL:
 		return mysqlType(req, options, col), false
-	case "postgresql":
+	case enginePostgreSQL:
 		return postgresType(req, options, col), false
-	case "sqlite":
+	case engineSQLite:
 		return sqliteType(req, options, col), false
-	case "clickhouse":
+	case engineClickHouse:
 		return clickhouseType(req, options, col), true
-	case "duckdb":
+	case engineDuckDB:
 		return duckdbType(req, options, col, param), true
-	case "googlesql":
+	case engineGoogleSQL:
 		return googlesqlType(req, options, col), true
-	case "mssql":
+	case engineMSSQL:
 		return mssqlType(req, options, col), true
 	default:
 		return "any", false

internal/codegen/golang/result.go

@@ -496,9 +496,9 @@ func placeholdersAreNamed(engine, text string, params []*plugin.Parameter) bool
 		}
 		var named bool
 		switch engine {
-		case "mssql", "googlesql":
+		case engineMSSQL, engineGoogleSQL:
 			named = strings.Contains(text, "@"+name)
-		case "clickhouse":
+		case engineClickHouse:
 			named = strings.Contains(text, "{"+name+":")
 		}
 		if !named {