Skip to content

[Bug] Keyboard shortcuts for Diff(-block) navigation only work in 'first' Diff-panel instanced #2390

@goran-w

Description

@goran-w

When I start SourceGit, in the first Diff panel that I visit the diff(-block)-navigation keys (Ctrl+Alt+Home/Up/Down/End) are working. But if I then visit another Diff panel, these keys are NOT working there. If I go back to the first Diff panel I visited, the keyboard shortcuts are still working there.

Examples (below it is assumed that selected items contain multiple diff-blocks) :

  • Session 1:

    • Start SourceGit (in History view), select a Commit in log-graph, switch to Changes (the Diff panel), select a changed item (if needed).
      • (Diff-navigation keys are working here.)
    • Switch to Local Changes view, select a changed item (Staged / Unstaged) to populate the Diff panel.
      • (Diff-navigation keys are NOT working here.)
    • Switch back to History view).
      • (Diff-navigation keys are working here, still.)
  • Session 2:

    • (Re-)Start SourceGit, switch to Local Changes view, select a changed item (Staged / Unstaged) to populate the Diff panel.
      • (Diff-navigation keys are working here.)
    • Switch to History view), select a Commit in log-graph, switch to Changes (the Diff panel), select a changed item (if needed).
      • (Diff-navigation keys are NOT working here.)
  • Switch back to Local Changes view.

    • (Diff-navigation keys are working here, still.)

As can be seen from these two session-examples, the order in which we visit the Diff panels matter. In the 1st visited panel (during ), the nav-keys work fine, but not so in the 2nd one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions