Commit 7f0d248
SK-2954: Add coverage to test-common, fix semgrep sensitive-info false positives
test-common never ran coverage or uploaded to Codecov, so common/ (which grew
substantially this session) was invisible to Codecov's patch/project checks.
Adds a coverage run + Codecov upload step matching v2/flowvault's pattern.
Also fixes .semgreprules/customRule.yml's check-sensitive-info regex: an
optional quote-capture group let its own backreference match empty string,
so any `keyword: value` matched regardless of quoting -- tightened to require
an actual quoted literal and exclude self-referential values (e.g. TOKEN =
'token'), which eliminates 28 false positives without any inline suppressions.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>1 parent f2611f6 commit 7f0d248
3 files changed
Lines changed: 21 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
0 commit comments