fix(mcp): reset connectionStatus when a server is switched to OAuth

An authType flip to oauth (via a plain authType change or an implicit
oauthClientId) cleared the cache but left connectionStatus='connected', so a
server that had not completed its OAuth flow falsely read as connected and the
OAuth-authorization-required prompt never showed. Reset to disconnected on any
switch to oauth, matching the create path. Adds the missing test assertion.

Author: waleedlatif1

apps/sim/lib/mcp/orchestration/server-lifecycle.test.ts

@@ -88,6 +88,11 @@ describe('MCP server lifecycle orchestration', () => {
 
     expect(result.success).toBe(true)
     expect(dbChainMockFns.set).toHaveBeenCalledWith(expect.objectContaining({ authType: 'oauth' }))
+    // Flipping to OAuth must reset the server to disconnected — it hasn't
+    // completed an auth flow, so it can't remain 'connected'.
+    expect(dbChainMockFns.set).toHaveBeenCalledWith(
+      expect.objectContaining({ connectionStatus: 'disconnected', lastConnected: null })
+    )
     expect(mockClearCache).toHaveBeenCalledWith('workspace-1')
   })
 })

apps/sim/lib/mcp/orchestration/server-lifecycle.ts

@@ -352,7 +352,10 @@ export async function performUpdateMcpServer(
     const shouldClearOauth = urlChanged || credsChanged
     const resolvedAuthType = (updateData.authType ?? currentServer.authType) as McpAuthType
     const authTypeChanged = resolvedAuthType !== currentServer.authType
-    if (shouldClearOauth && resolvedAuthType === 'oauth') {
+    // Switching a server to OAuth (via creds/URL change or a plain authType flip)
+    // must reset it to disconnected: an OAuth server has not completed its auth
+    // flow, so it can't legitimately remain 'connected' (matches the create path).
+    if ((shouldClearOauth || authTypeChanged) && resolvedAuthType === 'oauth') {
       updateData.connectionStatus = 'disconnected'
       updateData.lastConnected = null
     }