refactor(search): apply the cleanup passes to the Sim Search surface

Drop three memos over cheap derivations, make the search setter's
callers honest about their dependencies, ignore a whitespace-only query
from a link, give a dropdown setup field its hint, and drop the query
from the URL when the composer leaves Search.

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/home/components/knowledge-search-results/knowledge-search-results.tsx

@@ -118,14 +118,10 @@ export function KnowledgeSearchResults({
    * The list also carries the viewer's legacy personal bases, which have no
    * workspace; a search names one workspace and refuses a base outside it.
    */
-  const knowledgeBaseIds = useMemo(
-    () =>
-      knowledgeBases
-        .filter((kb) => kb.workspaceId === workspaceId)
-        .slice(0, MAX_SEARCHED_KNOWLEDGE_BASES)
-        .map((kb) => kb.id),
-    [knowledgeBases, workspaceId]
-  )
+  const knowledgeBaseIds = knowledgeBases
+    .filter((kb) => kb.workspaceId === workspaceId)
+    .slice(0, MAX_SEARCHED_KNOWLEDGE_BASES)
+    .map((kb) => kb.id)
   const {
     data: results,
     isPending,
@@ -134,16 +130,13 @@ export function KnowledgeSearchResults({
   } = useWorkspaceKnowledgeSearch(workspaceId, knowledgeBaseIds, query)
   const { data: memberConnectors = [] } = useWorkspaceMemberConnectors(workspaceId)
   /** Every per-member connector still indexing for the viewer, in any base the search spans. */
-  const indexing = useMemo(
-    () => [
-      ...new Set(
-        memberConnectors
-          .filter(isIndexing)
-          .map((connection) => connectorName(connection.connectorType))
-      ),
-    ],
-    [memberConnectors]
-  )
+  const indexing = [
+    ...new Set(
+      memberConnectors
+        .filter(isIndexing)
+        .map((connection) => connectorName(connection.connectorType))
+    ),
+  ]
   const documents = useMemo(() => groupResultsByDocument(results ?? []), [results])
   const sourceTypes = useMemo(
     () => [...new Set(documents.map((result) => result.connectorType ?? 'upload'))],

apps/sim/app/workspace/[workspaceId]/home/components/search-sources/search-sources.tsx

@@ -169,14 +169,11 @@ export function SearchSources({ workspaceId }: SearchSourcesProps) {
   })
   const [setupConnector, setSetupConnector] = useState<SearchConnector | null>(null)
 
-  /** Connected sources first, then the rest alphabetically. */
-  const ordered = useMemo(() => {
-    const rank = (connector: SearchConnector) =>
-      connectionByType.get(connector.type)?.viewerMembership === 'connected' ? 0 : 1
-    return [...PERSONAL_SEARCH_CONNECTORS].sort(
-      (a, b) => rank(a) - rank(b) || a.meta.name.localeCompare(b.meta.name)
-    )
-  }, [connectionByType])
+  const rank = (connector: SearchConnector) =>
+    connectionByType.get(connector.type)?.viewerMembership === 'connected' ? 0 : 1
+  const ordered = [...PERSONAL_SEARCH_CONNECTORS].sort(
+    (a, b) => rank(a) - rank(b) || a.meta.name.localeCompare(b.meta.name)
+  )
 
   const startConnect = (connector: SearchConnector) => {
     const connection = connectionByType.get(connector.type)

apps/sim/app/workspace/[workspaceId]/home/components/search-sources/source-setup-modal.tsx

@@ -57,6 +57,7 @@ export function SourceSetupModal({
                 label: option.label,
               }))}
               placeholder={field.placeholder}
+              hint={field.description}
               required
             />
           ) : (

apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/mode-switcher/mode-switcher.test.tsx

@@ -5,11 +5,15 @@ import { act } from 'react'
 import { createRoot, type Root } from 'react-dom/client'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
-const { mockCaptureEvent } = vi.hoisted(() => ({ mockCaptureEvent: vi.fn() }))
+const { mockCaptureEvent, mockSetSearchQuery } = vi.hoisted(() => ({
+  mockCaptureEvent: vi.fn(),
+  mockSetSearchQuery: vi.fn(),
+}))
 
 vi.mock('next/navigation', () => ({
   useParams: () => ({ workspaceId: 'workspace-1' }),
 }))
+vi.mock('nuqs', () => ({ useQueryState: () => [null, mockSetSearchQuery] }))
 vi.mock('posthog-js/react', () => ({ usePostHog: () => null }))
 vi.mock('@/lib/posthog/client', () => ({ captureEvent: mockCaptureEvent }))
 
@@ -94,6 +98,20 @@ describe('ModeSwitcher', () => {
       workspace_id: 'workspace-1',
       mode: 'search',
     })
+    expect(mockSetSearchQuery).not.toHaveBeenCalled()
+  })
+
+  it('drops the search query from the URL when leaving Search', () => {
+    useMothershipModeStore.getState().setMode('search')
+    mount()
+    openMenu()
+
+    act(() => {
+      items()[0].dispatchEvent(new MouseEvent('click', { bubbles: true, button: 0 }))
+    })
+
+    expect(useMothershipModeStore.getState().mode).toBe('build')
+    expect(mockSetSearchQuery).toHaveBeenCalledWith(null, { history: 'replace', scroll: false })
   })
 
   it('does not report re-selecting the active mode', () => {

apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/mode-switcher/mode-switcher.tsx

@@ -11,8 +11,10 @@ import {
 } from '@sim/emcn'
 import { Check } from '@sim/emcn/icons'
 import { useParams } from 'next/navigation'
+import { useQueryState } from 'nuqs'
 import { usePostHog } from 'posthog-js/react'
 import { captureEvent } from '@/lib/posthog/client'
+import { searchQueryParam } from '@/app/workspace/[workspaceId]/home/search-params'
 import {
   MOTHERSHIP_MODES,
   type MothershipMode,
@@ -37,9 +39,13 @@ export const ModeSwitcher = memo(function ModeSwitcher() {
   const mode = useMothershipModeStore((state) => state.mode)
   const setMode = useMothershipModeStore((state) => state.setMode)
 
+  const [, setSearchQueryParam] = useQueryState(searchQueryParam.key, searchQueryParam.parser)
+
+  /** Leaving Search drops the query from the URL, so a clean URL always means no search is showing. */
   const handleSelect = (next: MothershipMode) => {
     if (next === mode) return
     setMode(next)
+    if (next !== 'search') void setSearchQueryParam(null, { history: 'replace', scroll: false })
     captureEvent(posthog, 'chat_mode_changed', { workspace_id: workspaceId, mode: next })
   }
 

apps/sim/app/workspace/[workspaceId]/home/home.tsx

@@ -475,11 +475,11 @@ export function Home({ chatId, userName, userId }: HomeProps) {
       prepareResourceViewForAgentTurn()
       sendMessage(trimmed || 'Analyze the attached file(s).', fileAttachments, contexts)
     },
-    [workspaceId, chatId, prepareResourceViewForAgentTurn, sendMessage]
+    [workspaceId, chatId, prepareResourceViewForAgentTurn, sendMessage, setSearchQuery]
   )
 
   /** An emptied search box returns to the sources; nothing else reads the cleared query. */
-  const clearSearch = useCallback(() => setSearchQuery(''), [])
+  const clearSearch = useCallback(() => setSearchQuery(''), [setSearchQuery])
 
   /** Summarize on a result: hand the document to the agent in Build mode. */
   const handleSummarize = useCallback(
@@ -488,7 +488,7 @@ export function Home({ chatId, userName, userId }: HomeProps) {
       setSearchQuery('')
       handleSubmit(prompt)
     },
-    [handleSubmit]
+    [handleSubmit, setSearchQuery]
   )
   /**
    * A chat that already exists opens in Build: its transcript is a
@@ -498,7 +498,7 @@ export function Home({ chatId, userName, userId }: HomeProps) {
   useEffect(() => {
     if (chatId) useMothershipModeStore.getState().setMode('build')
   }, [chatId])
-  const showSearchResults = composerMode === 'search' && searchQuery.length > 0
+  const showSearchResults = composerMode === 'search' && searchQuery.trim().length > 0
   const searchResults = showSearchResults ? (
     <KnowledgeSearchResults
       workspaceId={workspaceId}

apps/sim/app/workspace/[workspaceId]/home/search-params.ts

@@ -28,9 +28,10 @@ export const resourceUrlKeys = {
 
 /**
  * `q` is the composer's Search-mode query, so a search is a shareable,
- * bookmarkable link the way a search page's is. Present only while a search
- * is showing; the composer reads it once on mount to restore the query and
- * the Search mode. Filter-like, so it replaces the history entry.
+ * bookmarkable link. Present only while a search is showing: it is dropped
+ * when the box empties, on Summarize, and when the mode leaves Search. The
+ * composer reads it once on mount to restore the query and the Search mode.
+ * Filter-like, so it replaces the history entry.
  */
 export const searchQueryParam = {
   key: 'q',