Address PR review feedback (#5754)

- Preserve OAuth-pending state when a status reread is stale
- Keep concrete refresh errors sanitized and visible

Author: j15z

apps/sim/app/api/mcp/servers/[id]/refresh/route.test.ts

@@ -116,6 +116,28 @@ describe('MCP server refresh route', () => {
     )
   })
 
+  it('preserves OAuth pending when the status reread is still stale connected', async () => {
+    mockDiscoverServerTools.mockRejectedValueOnce(
+      new McpOauthAuthorizationRequiredError('server-1', 'OAuth Server')
+    )
+    mockSelect.mockReturnValueOnce(selectRows([initialServer]))
+
+    const request = new Request('http://localhost/api/mcp/servers/server-1/refresh', {
+      method: 'POST',
+    }) as NextRequest
+    const response = await POST(request, { params: Promise.resolve({ id: 'server-1' }) })
+    const body = await response.json()
+
+    expect(body.data).toEqual(
+      expect.objectContaining({
+        status: 'disconnected',
+        error: null,
+        toolCount: 0,
+        workflowsUpdated: 0,
+      })
+    )
+  })
+
   it('reports a sanitized discovery timeout when persistence leaves disconnected without an error', async () => {
     mockDiscoverServerTools.mockRejectedValueOnce(new Error('upstream request timeout'))
 

apps/sim/app/api/mcp/servers/[id]/refresh/route.ts

@@ -289,7 +289,7 @@ export const POST = withRouteHandler(
 
           if (!newerSuccessWonRace) {
             connectionStatus = 'disconnected'
-            lastError = discoveryError
+            lastError = oauthAuthorizationRequired ? null : discoveryError
             toolCount = 0
           }
         } else if (