fix tests

Author: icecrasher321

apps/sim/app/api/workflows/[id]/deploy/route.ts

@@ -48,8 +48,15 @@ export const GET = withRouteHandler(
         return createErrorResponse(error.message, error.status)
       }
 
+      /**
+       * A workflow is deployed only when an active version snapshot exists —
+       * the same definition POST and the v1 routes use. The legacy
+       * `workflow.isDeployed` flag is deliberately not consulted: when it
+       * disagrees with the version table the workflow cannot actually serve
+       * traffic, so reporting it as live would be untruthful.
+       */
       const deploymentSummary = await getWorkflowDeploymentSummary(id)
-      const isDeployed = deploymentSummary.activeDeployment !== null || workflowData.isDeployed
+      const isDeployed = deploymentSummary.activeDeployment !== null
 
       if (!isDeployed) {
         logger.info(`[${requestId}] Workflow is not deployed: ${id}`)

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx

@@ -17,6 +17,7 @@ import {
   ModalTabsList,
   ModalTabsTrigger,
   Tooltip,
+  toast,
 } from '@sim/emcn'
 import { createLogger } from '@sim/logger'
 import { toError } from '@sim/utils/errors'
@@ -357,13 +358,22 @@ export function DeployModal({
     }
 
     try {
-      await undeployMutation.mutateAsync({ workflowId: targetWorkflowId })
+      const result = await undeployMutation.mutateAsync({ workflowId: targetWorkflowId })
       if (!isWorkflowStillActive(targetWorkflowId)) return
       setUndeployTargetWorkflowId(null)
       onOpenChange(false)
+      /**
+       * Partial cleanup warnings (e.g. external subscription teardown left to
+       * background retries) surface as a toast so closing the modal does not
+       * silently swallow them.
+       */
+      if (result.warnings?.length) {
+        toast.warning('Workflow undeployed', { description: result.warnings.join(' ') })
+      }
     } catch (error: unknown) {
       if (!isWorkflowStillActive(targetWorkflowId)) return
       logger.error('Error undeploying workflow:', { error })
+      toast.error('Failed to undeploy workflow', { description: toError(error).message })
     }
   }
 

apps/sim/background/async-preprocessing-correlation.test.ts

@@ -115,6 +115,7 @@ describe('async preprocessing correlation threading', () => {
         status: 'active',
         archivedAt: null,
         lastQueuedAt: new Date('2025-01-01T00:00:00.000Z'),
+        deploymentOperationId: null,
       },
     ])
     mockLoadDeployedWorkflowState.mockResolvedValue({

apps/sim/background/webhook-execution.test.ts

@@ -293,7 +293,7 @@ describe('executeWebhookJob fault vs error handling', () => {
     )
   })
 
-  it('does not start queued webhook work after the workflow is undeployed', async () => {
+  it('acknowledges and skips queued webhook work after the workflow is undeployed', async () => {
     executionPreprocessingMockFns.mockPreprocessExecution.mockResolvedValueOnce({
       success: true,
       actorUserId: 'user-1',
@@ -308,10 +308,11 @@ describe('executeWebhookJob fault vs error handling', () => {
       executionTimeout: { async: 120_000 },
     })
 
-    await expect(executeWebhookJob(payload)).rejects.toThrow(
-      'Workflow workflow-1 is no longer deployed'
-    )
+    const result = await executeWebhookJob(payload)
+
+    expect(result).toMatchObject({ skipped: true, success: false, workflowId: 'workflow-1' })
     expect(mockExecuteWorkflowCore).not.toHaveBeenCalled()
+    expect(mockReleaseExecutionSlot).toHaveBeenCalled()
   })
 
   it('releases the reservation when idempotency returns a cached result', async () => {

apps/sim/background/webhook-execution.ts

@@ -413,7 +413,25 @@ async function executeWebhookJobInternal(
     throw new Error(`Workflow ${payload.workflowId} not found during preprocessing`)
   }
   if (!workflowRecord.isDeployed || workflowRecord.archivedAt) {
-    throw new Error(`Workflow ${payload.workflowId} is no longer deployed`)
+    /**
+     * A queued delivery racing an undeploy/archive is an expected terminal
+     * condition, not a job fault: acknowledge and skip so workers do not
+     * record a failed job (or burn retries) for work that must never run.
+     */
+    logger.info(`[${requestId}] Skipping webhook execution for undeployed workflow`, {
+      workflowId: payload.workflowId,
+      archived: Boolean(workflowRecord.archivedAt),
+    })
+    await releaseExecutionSlot(executionId)
+    return {
+      success: false,
+      skipped: true,
+      workflowId: payload.workflowId,
+      executionId,
+      output: {},
+      executedAt: new Date().toISOString(),
+      provider: payload.provider,
+    }
   }
 
   const workspaceId = workflowRecord.workspaceId