improvement(logs): name the projection warning's read/write phase explicitly

Author: waleedlatif1

apps/sim/lib/logs/execution/trace-secret-projection.test.ts

@@ -1022,7 +1022,7 @@ describe('projectTraceSpansForSecrets', () => {
       executionId: 'execution-1',
       workflowId: 'workflow-1',
       workspaceId: 'workspace-1',
-      readOnly: false,
+      phase: 'write',
       spanId: 'span-1',
       spanType: 'function',
       field: 'output',
@@ -1094,7 +1094,7 @@ describe('projectTraceSpansForSecrets whole-trace content budget', () => {
       'Trace content exceeded the projection budget; withholding the remaining spans',
       expect.objectContaining({
         executionId: 'execution-1',
-        readOnly: true,
+        phase: 'read',
         retainedSpanCount: 2,
         withheldSpanCount: 2,
       })
@@ -1123,7 +1123,7 @@ describe('projectTraceSpansForSecrets whole-trace content budget', () => {
     expect(projected[0].contentWithheld).toBe(true)
     expect(warnMock).toHaveBeenCalledWith(
       'Trace secret projection failed; retaining structural spans only',
-      expect.objectContaining({ executionId: 'execution-1', readOnly: true })
+      expect.objectContaining({ executionId: 'execution-1', phase: 'read' })
     )
   })
 

apps/sim/lib/logs/execution/trace-secret-projection.ts

@@ -139,25 +139,28 @@ class TraceSecretProjectionError extends Error {
  */
 class TraceContentBudgetError extends TraceSecretProjectionError {}
 
-/** Identifies the run behind a projection warning; every field is a stored id or a mode flag. */
+/**
+ * Identifies the run behind a projection warning. `phase` says whether the run was being written
+ * to the log or a stored log was being read for display.
+ */
 interface ProjectionLogDetails {
   executionId?: string
   workflowId?: string
   workspaceId?: string
-  readOnly: boolean
+  phase: 'read' | 'write'
 }
 
 function projectionLogDetails(
   store: LargeValueStoreContext,
-  readOnly: boolean
+  phase: ProjectionLogDetails['phase']
 ): ProjectionLogDetails {
   return {
     ...filterUndefined({
       executionId: store.executionId,
       workflowId: store.workflowId,
       workspaceId: store.workspaceId,
     }),
-    readOnly,
+    phase,
   }
 }
 
@@ -203,7 +206,7 @@ function createProjectionContext(
     sourceLargeValueBytes: 0,
     storedLargeValueBytes: 0,
     storedLargeValueCount: 0,
-    logDetails: projectionLogDetails(store, !allowLargeValueWrites),
+    logDetails: projectionLogDetails(store, allowLargeValueWrites ? 'write' : 'read'),
   }
 }
 
@@ -1647,7 +1650,7 @@ export async function enforceTraceSpanSecretInvariant(
     return traceSpans
   } catch (error) {
     logger.warn('Trace secret invariant failed; retaining structural spans only', {
-      ...projectionLogDetails(options.store, false),
+      ...projectionLogDetails(options.store, 'write'),
       failure: describeProjectionFailure(error),
     })
     return structuralOnlyTraceSpans(traceSpans)
@@ -1667,7 +1670,7 @@ export async function projectTraceSpansForSecrets(
   }
 
   const allowLargeValueWrites = options.allowLargeValueWrites !== false
-  const logDetails = projectionLogDetails(options.store, !allowLargeValueWrites)
+  const logDetails = projectionLogDetails(options.store, allowLargeValueWrites ? 'write' : 'read')
   try {
     const matcher = createResolvedSecretMatcher(options.registry.getActiveMatches(), {
       preserveNamedProvenanceLabels: true,