fix(integrations): tighten Oracle HCM selectors

Author: Bill Leoutsakos

apps/sim/lib/selectors/server/providers/oracle-fusion-hcm.test.ts

@@ -1,4 +1,5 @@
 import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { OracleFusionHcmOperationError } from '@/lib/internal/oracle-fusion-hcm/errors'
 import { selectorManifest } from '@/lib/selectors/manifest'
 import {
   SelectorConnectionUnavailableError,
@@ -116,6 +117,7 @@ describe('Oracle Fusion HCM selectors', () => {
         absences: [
           {
             absenceId: '3',
+            personId: '1',
             absenceType: 'Vacation',
             startDate: '2026-01-01',
             endDate: '2026-01-02',
@@ -311,6 +313,76 @@ describe('Oracle Fusion HCM selectors', () => {
     ).rejects.toBeInstanceOf(SelectorContextUnavailableError)
   })
 
+  it.each([undefined, '2'])('rejects a listed absence with personId %s', async (personId) => {
+    mocks.listAbsences.mockResolvedValueOnce({
+      success: true,
+      output: {
+        absences: [{ absenceId: '3', personId, absenceType: 'Vacation' }],
+        count: 1,
+        hasMore: false,
+        limit: 50,
+        offset: 0,
+      },
+    })
+    const attachment = oracleFusionHcmSelectorAttachments['oracle_fusion_hcm.absences']
+    const input = args({
+      selectorKey: 'oracle_fusion_hcm.absences',
+      context: {
+        domain: 'https://acme.fa.ocs.oraclecloud.com',
+        username: 'reader',
+        password: 'secret',
+        personId: '1',
+      },
+    })
+
+    await expect(
+      attachment.execute(input, await prepare(attachment, input))
+    ).rejects.toBeInstanceOf(SelectorContextUnavailableError)
+  })
+
+  it('returns a missing detail when Oracle reports 404', async () => {
+    const context = {
+      domain: 'https://acme.fa.ocs.oraclecloud.com',
+      username: 'reader',
+      password: 'secret',
+      personId: '1',
+    }
+    for (const [key, id, mock] of [
+      ['workers', '1', mocks.getWorker],
+      ['assignments', '2', mocks.getAssignment],
+      ['absences', '3', mocks.getAbsence],
+    ] as const) {
+      mock.mockRejectedValueOnce(new OracleFusionHcmOperationError('not found', 404))
+      const attachment = oracleFusionHcmSelectorAttachments[`oracle_fusion_hcm.${key}`]
+      const input = args({
+        selectorKey: `oracle_fusion_hcm.${key}`,
+        context,
+        request: { kind: 'detail', id },
+      })
+
+      await expect(attachment.execute(input, await prepare(attachment, input))).resolves.toEqual({
+        kind: 'detail',
+        item: null,
+      })
+    }
+  })
+
+  it('keeps malformed detail requests and list 404s as context errors', async () => {
+    const attachment = oracleFusionHcmSelectorAttachments['oracle_fusion_hcm.workers']
+    for (const [status, request] of [
+      [400, { kind: 'detail', id: '1' }],
+      [404, { kind: 'list' }],
+    ] as const) {
+      const mock = request.kind === 'detail' ? mocks.getWorker : mocks.listWorkers
+      mock.mockRejectedValueOnce(new OracleFusionHcmOperationError('invalid context', status))
+      const input = args({ request })
+
+      await expect(
+        attachment.execute(input, await prepare(attachment, input))
+      ).rejects.toBeInstanceOf(SelectorContextUnavailableError)
+    }
+  })
+
   it.each(['../workers/1', '1,absenceTypeId=2', '0', '9223372036854775808'])(
     'rejects invalid dependent person ID %s before provider preparation',
     async (invalidId) => {

apps/sim/lib/selectors/server/providers/oracle-fusion-hcm.ts

@@ -56,6 +56,10 @@ function publicSelectorError(error: unknown): never {
   throw new SelectorOptionsUnavailableError(error.status === 429 ? 429 : 502)
 }
 
+function isMissingDetail(error: unknown): boolean {
+  return error instanceof OracleFusionHcmOperationError && error.status === 404
+}
+
 const destination = {
   kind: 'user-controlled' as const,
   async prepare(args: ExecuteServerSelectorArgs): Promise<PreparedOracleFusionHcm> {
@@ -119,6 +123,9 @@ export const oracleFusionHcmSelectorAttachments = {
         )
       } catch (error) {
         args.signal?.throwIfAborted()
+        if (args.request.kind === 'detail' && isMissingDetail(error)) {
+          return detailSelectorResult(null)
+        }
         publicSelectorError(error)
       }
     },
@@ -162,6 +169,9 @@ export const oracleFusionHcmSelectorAttachments = {
         )
       } catch (error) {
         args.signal?.throwIfAborted()
+        if (args.request.kind === 'detail' && isMissingDetail(error)) {
+          return detailSelectorResult(null)
+        }
         publicSelectorError(error)
       }
     },
@@ -200,22 +210,30 @@ export const oracleFusionHcmSelectorAttachments = {
           args.signal
         )
         return listSelectorResult(
-          result.output.absences.map((absence) => ({
-            id: absence.absenceId,
-            label:
-              [absence.absenceType, absence.startDate, absence.endDate]
-                .filter(Boolean)
-                .join(' · ') || absence.absenceId,
-            meta: {
-              status: absence.displayStatusMeaning || absence.displayStatus,
-              startDate: absence.startDate,
-              endDate: absence.endDate,
-            },
-          })),
+          result.output.absences.map((absence) => {
+            if (absence.personId !== prepared.personId) {
+              throw new SelectorContextUnavailableError()
+            }
+            return {
+              id: absence.absenceId,
+              label:
+                [absence.absenceType, absence.startDate, absence.endDate]
+                  .filter(Boolean)
+                  .join(' · ') || absence.absenceId,
+              meta: {
+                status: absence.displayStatusMeaning || absence.displayStatus,
+                startDate: absence.startDate,
+                endDate: absence.endDate,
+              },
+            }
+          }),
           nextCursor(result.output.hasMore, offset, result.output.limit)
         )
       } catch (error) {
         args.signal?.throwIfAborted()
+        if (args.request.kind === 'detail' && isMissingDetail(error)) {
+          return detailSelectorResult(null)
+        }
         publicSelectorError(error)
       }
     },