fix(managed-agents): address review round 2

- don't complete on idle status while a requires_action is still outstanding
- vaults: combobox → dropdown so multiSelect actually attaches multiple vaults
- auto-select a freshly-pasted service-account credential (onCreated through the connect modal)

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/connect-service-account-modal.tsx

@@ -108,6 +108,8 @@ interface ConnectServiceAccountModalProps {
   credentialDisplayName?: string
   /** Existing description, used to seed reconnect-capable modals. */
   credentialDescription?: string
+  /** Called with the new credential id after a successful create (token-paste providers). */
+  onCreated?: (credentialId: string) => void
 }
 
 /**
@@ -132,6 +134,7 @@ export function ConnectServiceAccountModal({
   credentialId,
   credentialDisplayName,
   credentialDescription,
+  onCreated,
 }: ConnectServiceAccountModalProps) {
   const clientCredentialDescriptor = getClientCredentialAccountDescriptor(serviceAccountProviderId)
   if (clientCredentialDescriptor) {
@@ -162,6 +165,7 @@ export function ConnectServiceAccountModal({
         credentialId={credentialId}
         initialDisplayName={credentialDisplayName}
         initialDescription={credentialDescription}
+        onCreated={onCreated}
       />
     )
   }

apps/sim/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/token-service-account-modal.tsx

@@ -72,6 +72,8 @@ interface TokenServiceAccountModalProps {
   credentialId?: string
   initialDisplayName?: string
   initialDescription?: string
+  /** Called with the new credential id after a successful create (not reconnect). */
+  onCreated?: (credentialId: string) => void
 }
 
 /**
@@ -91,6 +93,7 @@ export function TokenServiceAccountModal({
   credentialId,
   initialDisplayName,
   initialDescription,
+  onCreated,
 }: TokenServiceAccountModalProps) {
   const [apiToken, setApiToken] = useState('')
   const [domain, setDomain] = useState('')
@@ -139,14 +142,15 @@ export function TokenServiceAccountModal({
           description: description.trim() || undefined,
         })
       } else {
-        await createCredential.mutateAsync({
+        const created = await createCredential.mutateAsync({
           workspaceId,
           type: 'service_account',
           providerId: descriptor.providerId,
           ...secretFields,
           displayName: displayName.trim() || undefined,
           description: description.trim() || undefined,
         })
+        onCreated?.(created.credential.id)
       }
       onOpenChange(false)
     } catch (err: unknown) {

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/credential-selector/credential-selector.tsx

@@ -432,16 +432,17 @@ export function CredentialSelector({
       {showServiceAccountModal && serviceAccountService?.serviceAccountProviderId && (
         <ConnectServiceAccountModal
           open={showServiceAccountModal}
-          onOpenChange={(open) => {
-            setShowServiceAccountModal(open)
-            if (!open) refetchCredentials()
-          }}
+          onOpenChange={setShowServiceAccountModal}
           workspaceId={workspaceId}
           serviceAccountProviderId={
             serviceAccountService.serviceAccountProviderId as ServiceAccountProviderId
           }
           serviceName={serviceAccountService.name}
           serviceIcon={serviceAccountService.icon}
+          onCreated={(newCredentialId) => {
+            setStoreValue(newCredentialId)
+            refetchCredentials()
+          }}
         />
       )}
     </div>

apps/sim/blocks/blocks/managed_agent.ts

@@ -75,10 +75,10 @@ export const ManagedAgentBlock: BlockConfig = {
     {
       id: 'vaults',
       title: 'Credential vaults',
-      type: 'combobox',
+      type: 'dropdown',
       required: false,
       placeholder: 'Optional — pick zero or more OAuth vaults',
-      commandSearchable: true,
+      searchable: true,
       multiSelect: true,
       options: [],
       dependsOn: ['credential'],

apps/sim/lib/managed-agents/run-session.test.ts

@@ -121,6 +121,23 @@ describe('runManagedAgentSession', () => {
     expect(mocks.sleep).toHaveBeenCalled() // backed off while running
   })
 
+  it('does not complete on idle status while a requires_action is outstanding', async () => {
+    // Stream 1: text then a requires_action idle (pending), then closes.
+    // Reconnect: nothing new, status idle — but must NOT complete (pending).
+    // Stream 2: end_turn → complete.
+    scriptStreamBatches([
+      [msg('e1', 'partial'), idle('r1', 'requires_action')],
+      [idle('e2', 'end_turn')],
+    ])
+    mocks.getSession.mockResolvedValue({ status: 'idle' })
+
+    const result = await runManagedAgentSession({ ...BASE })
+
+    expect(result.ok).toBe(true)
+    expect(result.content).toBe('partial')
+    expect(mocks.openSessionStream).toHaveBeenCalledTimes(2) // reopened rather than completing early
+  })
+
   it('does not complete on a fresh idle before the agent has started', async () => {
     // Stream closes immediately with nothing; catch-up empty; status idle but no
     // activity yet → must NOT complete. Then it starts and finishes.

apps/sim/lib/managed-agents/run-session.ts

@@ -121,6 +121,10 @@ export async function runManagedAgentSession(
   const startedAt = Date.now()
   let backoffMs = RECONNECT_BACKOFF_START_MS
   let sawActivity = false
+  // A `requires_action` idle is a pending pause (waiting on a tool result), not
+  // a finished turn. Tracking it prevents the quiet-status path from reporting
+  // an in-progress session complete; it clears once the session resumes.
+  let requiresActionOutstanding = false
   let terminal: Terminal | null = null
 
   const process = async (event: AnthropicSessionEvent): Promise<boolean> => {
@@ -132,6 +136,12 @@ export async function runManagedAgentSession(
     ) {
       sawActivity = true
     }
+    if (event.type === 'session.status_running' || event.type === 'agent.message') {
+      requiresActionOutstanding = false
+    }
+    if (event.type === 'session.status_idle' && event.stop_reason?.type === 'requires_action') {
+      requiresActionOutstanding = true
+    }
     const outcome = await handleEvent({ event, assistantText, apiKey, sessionId, signal })
     if (outcome) {
       terminal = outcome
@@ -190,7 +200,7 @@ export async function runManagedAgentSession(
         terminal = { status: 'error', reason: 'Session terminated.' }
         break
       }
-      if (snapshot?.status === 'idle' && sawActivity) {
+      if (snapshot?.status === 'idle' && sawActivity && !requiresActionOutstanding) {
         terminal = { status: 'complete' }
         break
       }