Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the “GetToolForList” lookup used during link-following (when a link’s tool is "default" and the target is a CmPossibilityList) from the obsolete XCore Mediator.SendMessage reflection pathway to the FieldWorks FwUtils Publisher/Subscriber pub-sub system, reducing reliance on obsolete APIs and cross-assembly mediator messaging.
Changes:
- Replace
m_mediator.SendMessage("GetToolForList", ...)withPublisher.Publish(EventConstants.GetToolForList, ...)inLinkListener. - Add
EventConstants.GetToolForListsubscription/unsubscription inAreaListener. - Convert the handler from
OnGetToolForList(mediator/reflection shape) to a pub-sub handler that returns the tool name viaparameters[1].
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Src/xWorks/LinkListener.cs | Publishes GetToolForList via pub-sub instead of calling obsolete mediator reflection. |
| Src/LexText/LexTextDll/AreaListener.cs | Subscribes to GetToolForList and provides the handler to map a list to its editing tool name via the pub-sub payload. |
| @@ -512,9 +512,7 @@ private bool FollowActiveLink(bool suspendLoadingRecord) | |||
| // Thus we've created this method (on AreaListener) which we call awkwardly throught the mediator. | |||
| Subscriber.Subscribe(EventConstants.SetToolFromName, SetToolFromName); | ||
| Subscriber.Subscribe(EventConstants.ReloadAreaTools, ReloadAreaTools); | ||
| Subscriber.Subscribe(EventConstants.GetContentControlParameters, GetContentControlParameters); | ||
| Subscriber.Subscribe(EventConstants.GetToolForList, GetToolForList); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is